Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Most notably this contains: - upgraded libdparse with support for deprecated C-style alias declarations (-> dlang-community/libdparse#150) - has_public_example check Full changelog: dlang-community/D-Scanner@455cc3f...40d7561
wilzbach
force-pushed
the
dscanner-upgrade
branch
from
88bdc73 to
b9229d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important PRs:
1) Add support for C-style alias declarations
The D Grammar tries to deprecate
alias ref int xin favor of ...alias y = ref int- nope, that's not valid D. As DScanner didn't bother about this, we were forced to manually excludestd.traitsandstd.typeconsfrom the statically analysed modules.For more details about the D grammar issue: https://issues.dlang.org/show_bug.cgi?id=16020 or https://issues.dlang.org/show_bug.cgi?id=11632
-> This PR updates DScanner, removes the hard-coded exclusion & fixes trivial issues. For more complex (or controversial ones), I added the modules to the respective blacklists.
2) Has public example
Checking for public functions without a ddoced unittest has previously been a separate check as DScanner didn't allow for selective checks. Now that DScanner supports selective checks, this check got backported to DScanner
See also: cleanup PR at dlang/tools (dlang/tools#237)
I used my filter script to generate the new blacklist for
has_public_example.