Merged
Conversation
- has_public_example has been moved to Dscanner - Reduce to a DUB single file setup for simplicity
wilzbach
added
the
PR.Blocked
wilzbach
removed
the
PR.Blocked
CyberShadow
reviewed
Jun 21, 2017
posix.mak
Outdated
| $(DMD): | ||
| make -C $(DMD_PATH) -f posix.mak all | ||
|
|
||
| $(PHOBOS): |
Member
There was a problem hiding this comment.
I don't see where this macro is defined.
| set -uexo pipefail | ||
|
|
||
| DIGGER_DIR="../digger" | ||
| DIGGER="../digger/digger" |
Member
There was a problem hiding this comment.
Why? Lots of new redundant bash code doesn't seem like an improvement.
.travis.yml
Outdated
| script: | ||
| - ./travis.sh | ||
| - ./travis.sh clone | ||
| - ./travis.sh setups-repos |
Member
There was a problem hiding this comment.
Fairly sure you meant setup-repos
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
changed the title
wilzbach
force-pushed
the
cleanup
branch
3 times, most recently
from
895d2c1 to
7f2f3e7
Compare
Contributor
Author
|
Okay I think I found a way to build the |
andralex
approved these changes
Jun 30, 2017
Member
|
Whoops, thought we merged this one already. |
CyberShadow
approved these changes
Jun 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the upcoming Dscanner PR,
has_public_exampeis no longer needed.This means we can cleanup the
toolsdirectory :)Phobos checks out a fixed version of
tools(https://github.com/dlang/phobos/blob/548630d2a9ba95f079193d7b47ed8cd685c0f7c8/circleci.sh#L106), but it's probably best to wait a bit until allhas_public_exampleis available at Phobos.As a bonus this adds a small testsuite for the tests_extractor.