Merge remote-tracking branch 'upstream/stable' into merge_stable #5748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strings. The from*String functions in std.datetime did not have tests to make sure that they worked with various character types or various levels of constness, and some optimizations that were done to the from*String functions on DateTime for 2.076 broke them for const strings. So, this adds tests for all character types and levels of constness to each of the from*String function in std.datetime, and fixes the functionality for DateTime that then doesn't pass the tests.
Fix issue 17801: DateTime.fromISOExtString no longer works with const strings. merged-on-behalf-of: Petar Kirov <ZombineDev@users.noreply.github.com>
Fix issue 13348 - byGrapheme is not pure merged-on-behalf-of: unknown
Adjust @Safe-ty of 64-bit real unittest.
ddoc, add missing isSIMDVector to the index trait merged-on-behalf-of: Petar Kirov <ZombineDev@users.noreply.github.com>
Conflicts: std/uni.d
MartinNowak
requested review from
DmitryOlshansky,
JackStouffer,
PetarKirov,
dnadlinger and
jmdavis
as code owners
Contributor
|
Thanks for your pull request, @MartinNowak! Bugzilla references
|
wilzbach
approved these changes
Oct 1, 2017
| { | ||
| // TODO: Bidirectional access | ||
| static struct Result | ||
| static struct Result(R) |
Contributor
There was a problem hiding this comment.
FWIW this change from #5723 looks weird. The template parameter Range is the same and should be available. After all, it worked fine before ...
std/uni.d
Outdated
| import std.traits; // isConvertibleToString, isIntegral, isSomeChar, | ||
| // isSomeString, Unqual | ||
| import std.exception : enforce, collectException; | ||
| import core.memory: pureMalloc, pureRealloc, pureFree; |
Contributor
There was a problem hiding this comment.
CI is failing due to the missing space here -> appended a commit to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts:
std/uni.d