Fix some comments from #5902 #6095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @joakim-noah! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
joakim-noah
commented
Jan 30, 2018
| data into a single file called tzdata and stores it in the directory | ||
| below. | ||
| +/ | ||
| enum defaultTZDatabaseDir = ""; |
Contributor
Author
There was a problem hiding this comment.
First StdDdoc comment I've written, not sure if I need to put this blank enum here.
Member
There was a problem hiding this comment.
You do. You can't document a symbol that isn't there.
joakim-noah
commented
Jan 30, 2018
| assert(bufferSize < Element.sizeof); | ||
|
|
||
| // Check if we don't fill up a whole block buffer. | ||
| // Check if the incoming data doesn't fill up a whole block buffer. |
MetaLang
approved these changes
Jan 30, 2018
quickfur
approved these changes
Jan 30, 2018
Contributor
|
Used the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.