-
-
Notifications
You must be signed in to change notification settings - Fork 748
Fix some comments from #5902 #6095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -505,15 +505,16 @@ struct MurmurHash3(uint size /* 32 or 128 */ , uint opt = size_t.sizeof == 8 ? 6 | |
| // Buffer should never be full while entering this function. | ||
| assert(bufferSize < Element.sizeof); | ||
|
|
||
| // Check if we don't fill up a whole block buffer. | ||
| // Check if the incoming data doesn't fill up a whole block buffer. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MetaLang, this is for you. |
||
| if (bufferSize + data.length < Element.sizeof) | ||
| { | ||
| buffer.data[bufferSize .. bufferSize + data.length] = data[]; | ||
| bufferSize += data.length; | ||
| return; | ||
| } | ||
|
|
||
| // Check if we have some leftover data in the buffer. Then fill the first block buffer. | ||
| // Check if there's some leftover data in the first block buffer, and | ||
| // fill the remaining space first. | ||
| if (bufferSize != 0) | ||
| { | ||
| const bufferLeeway = Element.sizeof - bufferSize; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First
StdDdoccomment I've written, not sure if I need to put this blank enum here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do. You can't document a symbol that isn't there.