[refactor] posix.mak: Enforce whitespace before opening parenthesis for version …

[ibuclaw]

https://github.com/dlang/phobos/pull/6717/files#diff-228b518f4545d060f900578830ade5da

The rest is just mechanical.

This should be reflected in the style guide also.

https://dlang.org/dstyle.html#phobos_whitespace

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6717"

[n8sh]

Churn aside, enforcing this is questionable because version( appears more times in phobos than version (. What is the basis for making the minority use the required convention?

[ibuclaw]

What is the basis for making the minority use the required convention?

version () outranks version() 3067 to 2316 across dmd, druntime and phobos. Ignoring dmd, it still has a small majority.

I'm adding new ports, and I'm seeing:

version( A )
  // ...
else version (B)
  // ...
else version ( C )
  // ...
else version(D)
  // ...
else version (E)
  // ...
else version( F )
  // ...

[ibuclaw]

Also, covering this in the style guide. dlang/dlang.org#2472

[n8sh]

I'm adding new ports, and I'm seeing

Yeah that looks pretty janky.

[ibuclaw]

As I've been asked:

Before.

59b8821eb714ded12db222feb4daed3c  generated/linux/release/64/libphobos2.a
b25f2d5031ba95a2b4363b12039d014e  generated/linux/release/64/libphobos2.so
b25f2d5031ba95a2b4363b12039d014e  generated/linux/release/64/libphobos2.so.0.82
b25f2d5031ba95a2b4363b12039d014e  generated/linux/release/64/libphobos2.so.0.82.0
c8795c44c8921969727c1158754ce226  generated/linux/release/64/libphobos2.so.0.82.o

After.

c2fea619446f1360e605c4cb4116bb4b  generated/linux/release/64/libphobos2.a
b25f2d5031ba95a2b4363b12039d014e  generated/linux/release/64/libphobos2.so
b25f2d5031ba95a2b4363b12039d014e  generated/linux/release/64/libphobos2.so.0.82
b25f2d5031ba95a2b4363b12039d014e  generated/linux/release/64/libphobos2.so.0.82.0
c8795c44c8921969727c1158754ce226  generated/linux/release/64/libphobos2.so.0.82.o

It is expected that archives don't have a consistent md5 after each rebuild.

[PetarKirov]

Good to see we're finally done with this syntax inconsistency for Phobos.