posix.mak: Enforce whitespace before opening version parenthesis

[ibuclaw]

Get everyone using the same style.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

[n8sh]

If this is being added to posix.max there should also be a line about it in https://github.com/dlang/dlang.org/blob/master/dstyle.dd. I recently checked it for guidance on version but couldn't find any.

[wilzbach]

Could we use this opportunity to normalize these too?

[wilzbach]

I'm all in favor of being consistent in the style, but may I ask why you picked this one?

> ~/dlang/phobos on master ± ag "version\(" | wc -l
714

> ~/dlang/phobos on master ± ag "version \(" | wc -l
545

[ibuclaw]

I'm all in favor of being consistent in the style, but may I ask why you picked this one?

You mean version style? Because it is a heavily used feature that has at least three different styles, frequently intermixed in the same condition statement!

[wilzbach]

You mean version style?

No I meant why version( and not version ) - see the output of the grep command.

[ibuclaw]

Ah, that would mean having its own regexp to catch that particular style.

I could use the same argument against the following also:

if ( cond )
switch ( cond )
while ( cond )
foreach ( var; array )

But to be really precise about this, we may need something smarter in order to lint, as you'd also want to catch e.g:

if ( cond1 ||
     cond2 )

[wilzbach]

Yeah, you want this to be a D-Scanner check, e.g.

dlang-community/D-Scanner#450
dlang-community/D-Scanner#348

However, I never managed to push these into D-Scanner (there were some controversies on how D-Scanner can access the tokens), but we now have a special branch phobos there into which we can push anything (even things Brian objects to).

[n8sh]

(superseded by #6717)