Skip to content

Add check for if constraint indendation#450

Merged
dlang-bot merged 2 commits intodlang-community:masterfrom
wilzbach:if_constraints_indent
Mar 22, 2018
Merged

Add check for if constraint indendation#450
dlang-bot merged 2 commits intodlang-community:masterfrom
wilzbach:if_constraints_indent

Conversation

@wilzbach
Copy link
Member

So I rewrote #394 to use the tokens stream instead 🎉
In the beginning I save for every line its indendation level and whether it starts with the if token.

As Phobos has been unified in February, only a few matches can be observed, but all are regressions :)

std/conv.d(5710:47)[warn]: If constraints should have the same indentation as the function
std/numeric.d(2613:9)[warn]: If constraints should have the same indentation as the function
std/numeric.d(2670:9)[warn]: If constraints should have the same indentation as the function
std/digest/crc.d(163:33)[warn]: If constraints should have the same indentation as the function
std/experimental/allocator/common.d(549:13)[warn]: If constraints should have the same indentation as the function
std/algorithm/searching.d(1323:9)[warn]: If constraints should have the same indentation as the function
std/algorithm/searching.d(1336:9)[warn]: If constraints should have the same indentation as the function
std/algorithm/searching.d(3365:9)[warn]: If constraints should have the same indentation as the function
std/algorithm/searching.d(3382:9)[warn]: If constraints should have the same indentation as the function
std/concurrency.d(465:38)[warn]: If constraints should have the same indentation as the function
std/concurrency.d(490:44)[warn]: If constraints should have the same indentation as the function
std/concurrency.d(499:60)[warn]: If constraints should have the same indentation as the function
std/range/package.d(7443:9)[warn]: If constraints should have the same indentation as the function
std/range/package.d(7449:9)[warn]: If constraints should have the same indentation as the function

@wilzbach
Copy link
Member Author

Rebased to master

@wilzbach
Copy link
Member Author

Rebased this to master, so it should finally be ready & mergable :)

@wilzbach wilzbach force-pushed the if_constraints_indent branch from 8c10f71 to cb073c3 Compare March 22, 2018 20:03
@wilzbach
Copy link
Member Author

Rebased to the new dscanner layout and for the 0.5.0 inclusion.

@ghost ghost added this to the 0.5.0 milestone Mar 22, 2018
@ghost ghost added the auto-merge label Mar 22, 2018
@ghost ghost added the auto-merge label Mar 22, 2018
@dlang-bot dlang-bot merged commit 9fa8756 into dlang-community:master Mar 22, 2018
@wilzbach wilzbach deleted the if_constraints_indent branch March 23, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants