Added version of receiveTimeout which takes a Duration. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I agree. The commit looks good. |
Member
There was a problem hiding this comment.
The test here is a bit alembicated. What's wrong with
if (false) receiveTimeout( dur!"msecs"(10), (int x) {}, (Variant x) {} );
The code will have to compile.
Contributor
There was a problem hiding this comment.
I wondered about that too, but then I saw that all the tests in that unittest block are written like that. I guess Sean is the one who has to answer that question.
Member
Author
There was a problem hiding this comment.
I was just copying how the other tests were written. I didn't think about it all that much. Though looking at them now, I would have written them as static asserts.
Member
|
OK, let's leave that to another day. |
tsbockman
pushed a commit
to tsbockman/phobos
that referenced
this pull request
Apr 7, 2016
Fix std.typecons.rtFieldDispatch() trailing whitespace.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have core.time.Duration, we should probably make it so that all of our functions which take a duration of time at least have a version which take a Duration rather than just a bare number. I'm not sure if we want to push that to the point that we eventually deprecate the versions that take bare numbers, but we certainly should add versions that take a Duration. So, here's one for std.concurrency.receiveTimeout.