Skip to content

Added version of receiveTimeout which takes a Duration. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Feb 27, 2011
Merged

Added version of receiveTimeout which takes a Duration. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions std/concurrency.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,11 @@ bool receiveTimeout(T...)( long ms, T ops )
return mbox.get( ms * TICKS_PER_MILLI, ops );
}

/++ ditto +/
bool receiveTimeout(T...)( Duration duration, T ops )
{
return receiveTimeout(duration.total!"msecs"(), ops);
}

unittest
{
Expand All @@ -519,6 +524,11 @@ unittest
{
receiveTimeout( 0, (int x) {}, (int x) {} );
} ) );

assert( __traits( compiles,
{
receiveTimeout( dur!"msecs"(10), (int x) {}, (Variant x) {} );
Copy link
Member

@andralex andralex Feb 26, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test here is a bit alembicated. What's wrong with

if (false) receiveTimeout( dur!"msecs"(10), (int x) {}, (Variant x) {} );

The code will have to compile.

Copy link
Contributor

@kyllingstad kyllingstad Feb 26, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about that too, but then I saw that all the tests in that unittest block are written like that. I guess Sean is the one who has to answer that question.

Copy link
Member Author

@jmdavis jmdavis Feb 27, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just copying how the other tests were written. I didn't think about it all that much. Though looking at them now, I would have written them as static asserts.

} ) );
}


Expand Down