Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious __EOF__ hiding existing declarations/tests #7778

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Feb 1, 2021

... and fix broken (public) unittests.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7778"

@maxhaton
Copy link
Member

maxhaton commented Feb 1, 2021


std/experimental/allocator/package.d(3365:1)[warn]: A unittest should be annotated with at least @safe or @system
--
  | std/experimental/allocator/package.d(3373:54)[warn]: Prefer the new "'alias' identifier '=' type ';'" syntax to the  old "'alias' type identifier ';'" syntax.
  | std/experimental/allocator/package.d(3531:16)[warn]: Local imports should specify the symbols being imported to avoid hiding local symbols.
  | std/experimental/allocator/package.d(3538:16)[warn]: Local imports should specify the symbols being imported to avoid hiding local symbols.
  | std/experimental/allocator/package.d(3569:1)[warn]: A unittest should be annotated with at least @safe or @system
  | std/experimental/allocator/package.d(3714:1)[warn]: A unittest should be annotated with at least @safe or @system
  | std/experimental/allocator/package.d(3752:1)[warn]: A unittest should be annotated with at least @safe or @system
  | std/experimental/allocator/package.d(3821:1)[warn]: A unittest should be annotated with at least @safe or @system
  | std/experimental/allocator/package.d(3846:1)[warn]: A unittest should be annotated with at least @safe or @system


Buildkite-style moaning

@@ -3323,8 +3323,6 @@ nothrow:
theAllocator.dispose(arr);
}

__EOF__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL. What was the point of it? Was this an accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, it was introduced at the end of the file just before a version(none) declaration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__EOF__

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just was about to create a PR to remove this.

I found it in my attempts to refactor phobos for phobos v2, my refactoring didn't do well with this. @MoonlightSentinel was on the beerconf call when I found it, thanks for fixing it!

Was this an accident?

I actually emailed Andrei, and he said he remembered some compiler bug making him put something like that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants