-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove spurious __EOF__ hiding existing declarations/tests #7778
Conversation
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7778" |
adb41ac
to
54670b0
Compare
Buildkite-style moaning |
54670b0
to
e64c4f7
Compare
e64c4f7
to
bec9d14
Compare
@@ -3323,8 +3323,6 @@ nothrow: | |||
theAllocator.dispose(arr); | |||
} | |||
|
|||
__EOF__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL. What was the point of it? Was this an accident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, it was introduced at the end of the file just before a version(none)
declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 3987 in 8b249a6
__EOF__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just was about to create a PR to remove this.
I found it in my attempts to refactor phobos for phobos v2, my refactoring didn't do well with this. @MoonlightSentinel was on the beerconf call when I found it, thanks for fixing it!
Was this an accident?
I actually emailed Andrei, and he said he remembered some compiler bug making him put something like that in.
... and fix broken (public) unittests.