Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus CI: Work around strange FreeBSD std.experimental.allocator unittest regression #3696

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

kinke
Copy link
Member

@kinke kinke commented Apr 10, 2021

No description provided.

@MoonlightSentinel
Copy link
Contributor

What fails on FreeBSD?

@kinke
Copy link
Member Author

kinke commented Apr 10, 2021

****** FAIL release64 std.experimental.allocator
core.exception.AssertError@std/experimental/allocator/package.d(3738): Assertion failure

Twice in a row for #3678 (I thought it was just spurious when seeing it the first time). Only with enabled optimizations and shared druntime/Phobos, and by the looks of it, not related to any recent changes. But it was green earlier today with master, and green before today's additions to #3678, which included these frontend changes.

@MoonlightSentinel
Copy link
Contributor

Note that the failing test was disabled for a long time due to a spurious __EOF__, see dlang/phobos#7778.
Did master already include this PR?.

@kinke
Copy link
Member Author

kinke commented Apr 10, 2021

Wow, wtf is/was that __EOF__?! Dude...

Still fails without this last-minute frontend diff, so something else added today in #3678 must have brought this issue to light. The __EOF__ was already removed in #3678 before today (Phobos wasn't touched today at all).

Edit: Okay, a FreeBSD image/packages change could be another reason, as the last successful #3678 run was some days ago, and the test is disabled for master which ran today successfully before merging 2.096.

@kinke kinke changed the title Investigate FreeBSD regression Cirrus CI: Work around strange FreeBSD std.experimental.allocator unittest regression Apr 10, 2021
@kinke kinke marked this pull request as ready for review April 10, 2021 17:47
@kinke kinke merged commit af6cec6 into ldc-developers:master Apr 10, 2021
@kinke kinke deleted the freebsd_test branch April 10, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants