Skip to content

Bump dscanner hash to a version that recognizes AliasAssign#8134

Closed
RazvanN7 wants to merge 1 commit intodlang:masterfrom
RazvanN7:Fix_dscanner_version
Closed

Bump dscanner hash to a version that recognizes AliasAssign#8134
RazvanN7 wants to merge 1 commit intodlang:masterfrom
RazvanN7:Fix_dscanner_version

Conversation

@RazvanN7
Copy link
Collaborator

@RazvanN7 RazvanN7 commented Jun 6, 2021

This should unblock @andralex 's AliasAssign PRs.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8134"

@RazvanN7 RazvanN7 closed this Jun 6, 2021
@RazvanN7 RazvanN7 reopened this Jun 6, 2021
@RazvanN7 RazvanN7 closed this Jun 6, 2021
@RazvanN7
Copy link
Collaborator Author

RazvanN7 commented Jun 6, 2021

For some reason, github created 2 identical PRs. When I closed one of them, the tests failed for the other. I simply closed the 2 and reopened a new PR: #8136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants