Skip to content

Update dscanner commit hash to include AliasAssign detection#8136

Merged
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:Dscanner_fix
Aug 27, 2021
Merged

Update dscanner commit hash to include AliasAssign detection#8136
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:Dscanner_fix

Conversation

@RazvanN7
Copy link
Collaborator

@RazvanN7 RazvanN7 commented Jun 6, 2021

I also disabled the newly added check for unused function return values because it had hundreds of failures. The check was added in August 2020, whereas phobos was using a version of dscanner from February 2020.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8136"

@kinke
Copy link
Contributor

kinke commented Jun 11, 2021

Wrt. the dscanner crash, see dlang-community/D-Scanner#823 (comment).

@RazvanN7
Copy link
Collaborator Author

Thanks @kinke . I will try to revert dlang-community/libddoc#44

@ibuclaw
Copy link
Member

ibuclaw commented Jul 7, 2021

(Forcing restart of Azure pipelines).

@RazvanN7 RazvanN7 force-pushed the Dscanner_fix branch 2 times, most recently from 498ccb5 to 9217002 Compare July 29, 2021 08:56
@RazvanN7
Copy link
Collaborator Author

RazvanN7 commented Aug 27, 2021

@thewilsonator I think this is ready to go so I'm gonna go ahead and merge this.

@dlang-bot dlang-bot merged commit c1e85e1 into dlang:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants