[WIP] Fix issue 16431 - Get dependency output directly from the dmd run#195
Closed
wilzbach wants to merge 2 commits intodlang:masterfrom
Closed
[WIP] Fix issue 16431 - Get dependency output directly from the dmd run#195wilzbach wants to merge 2 commits intodlang:masterfrom
wilzbach wants to merge 2 commits intodlang:masterfrom
Conversation
Contributor
|
@wilzbach, thanks for your PR! By analyzing the annotation information on this pull request, we identified @andralex, @CyberShadow and @leandro-lucarella-sociomantic to be potential reviewers. @andralex: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
Contributor
|
Contributor
|
PR duel! It's too late today for me to really look at rdmd.d anymore. Yours here seems to be more extensive than mine. So you may have caught details that I missed. |
ffe0f2d to
6dbe1ee
Compare
Contributor
Author
This was referenced Aug 28, 2016
Member
| // passing the compiler flags compilerFlags. Generates one large | ||
| // object file. | ||
| // Internal information needed for a build | ||
| struct BuildInformation { |
Member
There was a problem hiding this comment.
Adding more structure has been looming over rdmd. When exactly the time has come depends on whom you ask. My guess is we can wait a bit more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned on #194 I also went ahead and implemented Andrei's idea:
Okay I tried both (I started with the simpler solution) and the runtimes with a single file are pretty good.
I didn't publish this yet, because I wanted to clean the code more, but well before @aG0aep6G and I create more duplicate work :P
Single file
Multiple files
Tiny (one function file)
Medium (
mir.random -unittest)I used the following to run the benchmarks (10 samples, 3 runs), so the results should be stable.