use ctRegex + avoid array allocation#196
Merged
AndrejMitrovic merged 1 commit intodlang:masterfrom Aug 28, 2016
Merged
Conversation
Contributor
|
@wilzbach, thanks for your PR! By analyzing the annotation information on this pull request, we identified @andralex, @CyberShadow and @leandro-lucarella-sociomantic to be potential reviewers. @andralex: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
|
|
||
| // Have at it | ||
| if (chain(root.only, myDeps.byKey).array.anyNewerThan(lastBuildTime)) | ||
| if (chain(root.only, myDeps.byKey).anyNewerThan(lastBuildTime)) |
Contributor
There was a problem hiding this comment.
Can we use root.only.chain.myDeps.byKey.anyNewerThan(lastBuildTime) here?
There was a problem hiding this comment.
IMHO it is much harder to read than current version. I'd even go as far as to say that chain should never be used with UFCS unless it is used to append to already existing pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are two simple gotchas that I found during #195 and are independent to it or any refactoring.
Btw interestingly the compilation increases about 0.1s, but for the optimized build it decreases for nearly 0.2s
Compilation
dmd rdmd-master.ddmd rdmd.ddmd -O rdmd-master.ddmd -O rdmd.dRun time
With the used at #191
rdmd-masterrdmd-ctrdmd-master-optrdmd-ct-optFor a simple file with only two imports
rdmd-masterrdmd-ctrdmd-master-optrdmd-ct-optFor the benchmarks the following command was used :
edit:
rdmd-master= commit 1260719