Skip to content

Fix chmodzip#241

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:fix-chmodzip
Closed

Fix chmodzip#241
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:fix-chmodzip

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jul 3, 2017

RE https://github.com/dlang/tools/pull/233/files#r122169048

I'm not sure about these changes - on one hand if the script wasn't building no idea if it was actually used any more, on the other hand this needs to work correctly so that unzipping .zip files on POSIX results in the correct attributes being set for files, and I doubt this is tested automatically anywhere right now. @MartinNowak ?

Is this script even used anywhere at dlang? I couldn't find it anywhere at dlang.
The README is the only hit...
-> I would be in favor of simply removing this file.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach mentioned this pull request Jul 3, 2017
@CyberShadow
Copy link
Member

I'm totally fine with removing the file if @MartinNowak says he doesn't need it. (Why was it in this repo in the first place then? When did it stop being used?)

@MartinNowak
Copy link
Member

What does it even do? dlang.org is using chmgen to build d.tag for dman.
IMO we shoudl remove anything not strictly needed.

@CyberShadow
Copy link
Member

It changes attributes of files in zip archives, presumably so that you can create a zip archive that has correct attributes whether it's unpacked on Windows or POSIX.

@MartinNowak
Copy link
Member

It changes attributes of files in zip archives, presumably so that you can create a zip archive that has correct attributes whether it's unpacked on Windows or POSIX.

I've long added fileAttributes to std.zip, which allows to copy them from OS specific stat info. Let's remove the tool if we don't ship it nor use it anywhere.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jul 8, 2017

Let's remove the tool if we don't ship it nor use it anywhere.

-> #247

(used your comments to provide a helpful commit message. Thanks!)

@wilzbach wilzbach closed this Jul 8, 2017
@wilzbach wilzbach deleted the fix-chmodzip branch July 8, 2017 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants