Merged
Conversation
chmodzip changes attributes of files in zip archives, presumably so that you can create a zip archive that has correct attributes whether it's unpacked on Windows or POSIX. However, - fileAttributes are part of std.zip, which allows to copy them from OS specific stat info - chmodzip isn't used by any tool in the D ecosystem anymore (in fact it doesn't even build with a recent D compiler)
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Closed
That's really concerning. Why aren't we testing every tool? |
Contributor
Author
Because no one seemed to care before and introducing more automation is a slow and painful process. |
|
As a first step, can just start by trying to compile everything? |
JackStouffer
approved these changes
Jul 8, 2017
JackStouffer
left a comment
JackStouffer
left a comment
There was a problem hiding this comment.
the testing discussion doesn't need to hold up moving forward with this
CyberShadow
approved these changes
Jul 8, 2017
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chmodzipchanges attributes of files in zip archives,presumably so that you can create a zip archive
that has correct attributes whether it's unpacked on Windows or POSIX.
However,
doesn't even build with a recent D compiler)