Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: added '-u` to update PR from base branch #458

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Feat: added '-u` to update PR from base branch #458

merged 5 commits into from
Oct 2, 2024

Conversation

nzspambot
Copy link
Contributor

@nzspambot nzspambot commented Sep 30, 2024 •
edited
Loading

Summary

Added -u to update a PR from a base branch
Added a mergeStateStatuspill
Added a error theme colour
Changed warning colour to yellow from red

How did you test this change?

  1. built repo locally
  2. ran with --debug
  3. verified via debug that it was calling the function
8:56AM DEBU <ui/ui.go:163> Key pressed key=u
8:56AM DEBU <ui/ui.go:163> Key pressed key=y
8:56AM DEBU <ui/ui.go:163> Key pressed key=enter
8:56AM DEBU <tasks/pr.go:244> Updating PR prNumber=xxx
8:56AM DEBU <ui/ui.go:69> Starting task id=pr_update_xxx
8:56AM DEBU <tasks/pr.go:62> Running task cmd="gh pr update-branch xxx -R xxx/xxx"
8:56AM DEBU <ui/ui.go:505> Task finished id=pr_update_xxx
  1. verified PR in the UI was also updated
  2. verified the Pills in the UI changed as they are updated

Images

image
image
image
image
image

dlvhdr
dlvhdr reviewed Oct 1, 2024
View reviewed changes
Copy link
Owner

@dlvhdr dlvhdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man! Awesome PR 💪🏽

ui/components/prsidebar/prsidebar.go Outdated Show resolved Hide resolved
ui/components/pr/pr.go Outdated Show resolved Hide resolved
nzspambot and others added 2 commits October 2, 2024 13:55
@nzspambot @dlvhdr
Update ui/components/prsidebar/prsidebar.go
7e552ad 
Change naming

Co-authored-by: Dolev Hadar <6196971+dlvhdr@users.noreply.github.com>
@nzspambot @dlvhdr
Update ui/components/pr/pr.go
effab19 
Change naming

Co-authored-by: Dolev Hadar <6196971+dlvhdr@users.noreply.github.com>
@nzspambot
Copy link
Contributor Author

Thanks man! Awesome PR 💪🏽

No probs at all, just giving back to this awesome little project you have here 😎

I've committed your suggestions as well

@dlvhdr dlvhdr merged commit 08e5576 into dlvhdr:main Oct 2, 2024
rogeruiz added a commit to rogeruiz/gh-dash that referenced this pull request Oct 30, 2024
@rogeruiz
docs: Adding error property to theme example;
fa152f7 
With the additional property of `error` added to theme color in the
dlvhdr#458, the configuration of themes break if this property is
missing. This patch then adds it to the example to help users understand what's
required for theming `gh-dash`.
This was referenced Oct 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlvhdr dlvhdr dlvhdr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzspambot @dlvhdr