docs: Adding error property to theme example; #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the additional property of `error` added to theme color in the dlvhdr#458, the configuration of themes break if this property is missing. This patch then adds it to the example to help users understand what's required for theming `gh-dash`.
rogeruiz
added a commit
to rogeruiz/catppuccin-gh-dash
that referenced
this pull request
Oct 30, 2024
See more info at dlvhdr/gh-dash#469. This patch adds the error property and sets it to red with the warning property now being set to yellow.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the additional property of
erroradded to theme color in the#458, the configuration of themes break if this property is
missing. This patch then adds it to the example to help users understand what's
required for theming
gh-dash.How did you test this change?
If the
~/.config/gh-dash/config.ymlcontains a reference to atheme:colorsstanza but the
textstanza doesn't contain anerrorproperty, you will seethe following error.
And it breaks the rest of your shell session as well. It's probably a good idea
to fix that error with some defaults. But for now, I think we can avoid the
issue by updating the documentation.
Images/Videos
n/a