Bugfix pichillilorenzo#1602 windowType not checked in show function M…

…acOS
dmeuwissen · Mar 29, 2023 · 0637ccc · 0637ccc
1 parent a42b0e4
commit 0637ccc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/macos/Classes/InAppBrowser/InAppBrowserWindow.swift b/macos/Classes/InAppBrowser/InAppBrowserWindow.swift
@@ -228,12 +228,13 @@ public class InAppBrowserWindow : NSWindow, NSWindowDelegate, NSToolbarDelegate,
            !(NSApplication.shared.mainWindow?.tabbedWindows?.contains(self) ?? false),
            browserSettings?.windowType == .tabbed {
             NSApplication.shared.mainWindow?.addTabbedWindow(self, ordered: .above)
-        } else if !(NSApplication.shared.mainWindow?.childWindows?.contains(self) ?? false) {
+        } else if !(NSApplication.shared.mainWindow?.childWindows?.contains(self) ?? false),
+                browserSettings?.windowType == .child {
             NSApplication.shared.mainWindow?.addChildWindow(self, ordered: .above)
         } else {
             orderFront(self)
         }
-        NSApplication.shared.activate(ignoringOtherApps: true)
+        NSApplication.shared.activate(ignoringOtherApps: true)        
     }
 
     public func setSettings(newSettings: InAppBrowserSettings, newSettingsMap: [String: Any]) {