Calling show function on MacOS InAppBrowser breaks tabs

[dmeuwissen]

• I have read the Getting Started section
• I have already searched for the same problem

Environment

Technology	Version
Flutter version	3.7.1
Plugin version	6.0.0-beta.22
Android version	-
iOS version	-
macOS version	13.2.1
Xcode version	14.2

Device information: Macbook Pro M1

Description

Expected behavior:
When windowType = WindowType.TABBED and the show function is called on the InAppBrowser the tab should switch to the browser tab.

Current behavior:
A child window is opened.

Steps to reproduce

• windowType: WindowType.TABBED
• Open the browser with browser.openUrlRequest
• Switch back to the original tab (manually)
• Call widget.browser.show(); (with a button press)

Proposed fix

In the InAppBrowserWindow.swift file the show function is declared. The show function is missing a check to see if windowType is child.

Revised code:

 public func show() {
        if #available(macOS 10.12, *),
           !(NSApplication.shared.mainWindow?.tabbedWindows?.contains(self) ?? false),
           browserSettings?.windowType == .tabbed {
            NSApplication.shared.mainWindow?.addTabbedWindow(self, ordered: .above)
        } else if !(NSApplication.shared.mainWindow?.childWindows?.contains(self) ?? false),
                browserSettings?.windowType == .child {
            NSApplication.shared.mainWindow?.addChildWindow(self, ordered: .above)
        } else {
            orderFront(self)
        }
        NSApplication.shared.activate(ignoringOtherApps: true)        
    }

[github-actions]

👋 @dmeuwissen

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

[pichillilorenzo]

Does it work with latest version of the plugin?

[dmeuwissen]

Just tried with version: 6.0.0-beta.24+1 and the issue still persists Here is a screen recording of the issue. With the proposed fix the issue is solved.

screen-recording-2023-06-14-at-102413_I4KpdtBp.mp4

[github-actions]

This issue is stale and has been automatically closed because it has been open for more than 365 days with no activity. Please reopen a new issue if you still have it.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug and a minimal reproduction of the issue.