This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Fix gelu #1287
Merged
Fix gelu #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxjscience
approved these changes
Aug 5, 2020
Codecov Report
@@ Coverage Diff @@
## numpy #1287 +/- ##
==========================================
+ Coverage 83.60% 83.67% +0.06%
==========================================
Files 42 42
Lines 6375 6375
==========================================
+ Hits 5330 5334 +4
+ Misses 1045 1041 -4
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix gelu as discussed in #1282 (comment) which fixed by apache/mxnet#18827
Comments
@sxjscience