-
Notifications
You must be signed in to change notification settings - Fork 432
Conversation
Working with @yajiedesign, @TaoLv @pengzhao-intel @larroy @NeoZhangJiangyu to restructure the mxnet cmake build systems to make MKLDNN, MKL logic correct. In the past, the logic to set BLAS in mshadow.cmake is incorrect. Now, USE_BLAS have high priority than USE_MKL_IF_AVAILABLE.
BTW, how do you verify the current change? Could you paste the test results? |
We planned to update the 3 cmakefiles : ChooseBLAS.cmake, FindMKL.cmake and mshadow.cmake. the logic diagram is as the pdf. Red parts are original logic and green parts are new. cmake_mxnet_fixed.pdf |
we check the change by add debug message in cmakefile. message(STATUS "USE_MKL_IF_AVAILABLE ${USE_MKL_IF_AVAILABLE}") and test were passed. Record into the doc files. Thanks |
format the code
@pengzhao-intel, please help to review the format change. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yinghu5 please use this upstream branch in your MXNet PR then we can have an end to end validation. |
@yajiedesign @szha @eric-haibin-lin is it possible to have this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Working with @yajiedesign, @TaoLv @pengzhao-intel @larroy @NeoZhangJiangyu to restructure the mxnet cmake build systems to make MKLDNN, MKL logic correct.
In the past, the logic to set BLAS in mshadow.cmake is incorrect. Now, USE_BLAS have high priority than USE_MKL_IF_AVAILABLE.