[dask] Add a dummy sample to infer output shape. #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also fixes a performance issue in predict function that the booster might got serialized multiple times in |
|
This PR should significantly improve the performance for prediction. |
|
#6648 needs to be merged first. |
Codecov Report
@@ Coverage Diff @@
## master #6645 +/- ##
==========================================
+ Coverage 81.01% 81.12% +0.10%
==========================================
Files 13 13
Lines 3703 3703
==========================================
+ Hits 3000 3004 +4
+ Misses 703 699 -4
Continue to review full report at Codecov.
|
trivialfis
force-pushed
the
dask-shape
branch
2 times, most recently
from
c3cc599
to
593c8e6
Compare
This is for inferring shape with direct prediction (without DaskDMatrix). There are a few things that requires known output shape before carrying out actual prediction, including dask meta data, output dataframe columns. * Infer output shape based on local prediction. * Remove set param in predict function as it's not thread safe nor necessary as we now let dask to decide the parallelism. * Simplify prediction on `DaskDMatrix`.
trivialfis
force-pushed
the
dask-shape
branch
from
0a417a8
to
4a40f80
Compare
RAMitchell
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for inferring shape with direct prediction (without DaskDMatrix).
There are a few things that requires known output shape before carrying out
actual prediction, including dask meta data, output dataframe columns.
we now let dask to decide the parallelism.
DaskDMatrix.A small part extracted from #6638 with added test and remove redundant serialization.