Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dampening vs. damping #64

Closed
leberwurstsaft opened this issue Mar 22, 2023 · 1 comment
Closed

Dampening vs. damping #64

leberwurstsaft opened this issue Mar 22, 2023 · 1 comment

Comments

@leberwurstsaft
Copy link

Hey,

I noticed today that we misspelt "damping" in our project. "Dampening" means "to make slightly wet" 💦
Quick search in the project revealed the same mistake here.

DSWaveformImage/Sources/DSWaveformImage/WaveformImageTypes.swift

Line 136 in f46cf06

public let dampening: Dampening?

@dmrschmidt
Copy link
Owner

Oh my 🙈 Thanks for reporting this.

I'll make sure to deprecate this until next major release and replace it with correct spelling.

dmrschmidt added a commit that referenced this issue Apr 21, 2023
@dmrschmidt
fix silly spelling mistake in public API
0c23799 
Unfortunately this a backwards incompatible change to the public API,
so this will go out as a new major release. I decided against @deprecating it
since it's in too many places and too confusing with two almost identical
spellings. Plus it should mostly be an easy Find+Replace fix to migrate.

fixes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmrschmidt @leberwurstsaft