-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VisionOS #81
Conversation
Signed-off-by: Antonio Cabezuelo Vivo <antonio@tapsandswipes.com>
Hey @tapsandswipes, thanks for the PR. I haven't played around with visionOS at all so far. So before I can merge this, I'll need to add an example app to the repo. Not sure how involved this will be, so I can't say when I'd get done with that. |
No hurry. If I have time I'll create one and add it to this PR. |
Just a copy of the MacOS one Signed-off-by: Antonio Cabezuelo Vivo <antonio@tapsandswipes.com>
Done, I added a simple example app for VisionOS |
Hey @tapsandswipes, looks good in general, so I've just merged it in. Thanks a lot for this! |
Well... had to revert this due to 4888126#r130500076 Current state is in vision-os branch. I managed to get rid of the os(visionOS) related warnings, but then the .onChange failed again. I don't want to have open warnings in the library, so for until I figure out why the latest state in that branch still does not compile on Xcode 14 I'll leave it reverted. I must be missing something stupid. |
OK, I understand. I guess we need some |
The visionOS checks Ive already prefixed with that and it helped. However the actual updated onChange handler call now, despite being behind an if #available check, raises an error again. |
Add the changes needed to make this library usable in VisionOS