fix(HelpButton): Adds test when used inside texts #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3b08e1a:
|
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 10m PerformanceLighthouse report
|
langz
force-pushed
the
fix/add-demo-and-test-for-help-button-used-inside-text
branch
from
405f756 to
3b08e1a
Compare
tujoworker
approved these changes
May 9, 2022
tujoworker
pushed a commit
that referenced
this pull request
Jun 23, 2022
# [9.27.0](v9.26.1...v9.27.0) (2022-06-23) ### Bug Fixes * always hide content from DOM when Accordion is collapsed ([41cbd9b](41cbd9b)) * **Autocomplete:** enhance VoiceOver support ([#1472](#1472)) ([f469dd8](f469dd8)) * **Autocomplete:** ensure "no options" is read out in aria-live ([#1471](#1471)) ([254303f](254303f)) * **Autocomplete:** fix using tab + write issue ([#1473](#1473)) ([73f9655](73f9655)) * **Autocomplete:** make VoiceOver announce first if a certain item is selected ([#1479](#1479)) ([d32e980](d32e980)) * **Autocomplete:** touch device issue on first focus ([#1476](#1476)) ([5fcbf17](5fcbf17)) * **Avatar:** properly handle spacing props ([5841990](5841990)) * **Breadcrumb:** properly handle spacing props ([b713dad](b713dad)) * **DatePicker:** make keyboard usage in input not throw ([#1475](#1475)) ([d0756e2](d0756e2)) * **DatePicker:** rename testing attributes to data-testid ([2e1e285](2e1e285)) * **Dialog:** fix Modal backdrop / overlay false-positive click issue while e.g. selecting ([#1463](#1463)) ([91e69a8](91e69a8)) * **Dialog:** fix Safari issue not able to scroll ([3f6fb31](3f6fb31)) * **Dialog:** make Dialog not overflow iOS Safari viewport ([764e487](764e487)) * **Dropdown:** Missing properties in PropTypes ([#1384](#1384)) ([7a83b38](7a83b38)) * **HeightAnimation:** ensure quick state changes to react without animating from start to finish ([886b4cd](886b4cd)) * **HelpButton:** Adds test when used inside texts ([#1404](#1404)) ([f8a7795](f8a7795)) * **Icon:** fix stopwatch icon (16px) ([d57c617](d57c617)) * **Input:** add missing Input test for icon and clear button ([#1465](#1465)) ([be2b4a0](be2b4a0)) * **Input:** enhance vertical centering for Safari (mainly iOS) ([#1469](#1469)) ([dadb5f8](dadb5f8)) * **InputMasked:** fix integerLimit option when used with decimals ([14fe5d9](14fe5d9)) * **Modal:** fix data-testid usage in object defined props ([e023f13](e023f13)) * **Modal:** fix flaky overlay opacity color issue happening in Chrome browser ([86d875d](86d875d)) * **Radio:** fix radio button disabled issue when inside of group ([#1477](#1477)) ([e775792](e775792)) * **Table:** align HTML/CSS classes and types ([ff0be8d](ff0be8d)) * **Table:** fix sticky Table when no offset is given ([888564d](888564d)) * **Table:** simplify sticky table hook ([f1e7e3b](f1e7e3b)) * **Tag:** properly handle spacing props ([d7129d8](d7129d8)) * **Timeline:** properly handle spacing props ([e823c6e](e823c6e)) ### Features * **Autocomplete:** add support for data suffix_value ([#1467](#1467)) ([fe6fbb7](fe6fbb7)) * **DatePicker:** add size property to component ([#1438](#1438)) ([749a118](749a118)) * **DrawerList:** use CSS Grid for placing list content to enhance flexibility ([#1470](#1470)) ([93fac6b](93fac6b)) * **Icons:** add calendar and bookmark icon ([#1449](#1449)) ([61c9c11](61c9c11)) * **Input:** add inner_element property for internal usage (as of now) ([#1466](#1466)) ([d1b1b19](d1b1b19)) * **MediaQuery:** convert to TypeScript ([1a23e4f](1a23e4f)) * **Modal:** add "bypass_invalidation_selectors" property to omit element invalidation ([d9cb392](d9cb392)) * **NumberFormat:** add srLabel property to enhance more easily a11y for screen reader users ([#1480](#1480)) ([004d675](004d675)) * **Provider:** rewrite to TypeScript ([#1436](#1436)) ([66416d9](66416d9)) * **Table:** change colors of table ([1f3687f](1f3687f)) * **Table:** move to components and rewrite to TypeScript ([562940a](562940a)) * **Timeline:** date supports a list of dates ([#1464](#1464)) ([a5c1dcd](a5c1dcd)) * **Timeline:** rename name to title & date to subtitle with backwards compatibility ([#1468](#1468)) ([6607963](6607963))
|
🎉 This PR is included in version 9.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll use the HelpButton in a similar scenario, and thought it would be fine to have a test for this scenario