Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dropdown): Missing properties in PropTypes #1384

Merged
merged 2 commits into from
May 10, 2022
Merged

fix(Dropdown): Missing properties in PropTypes #1384

merged 2 commits into from
May 10, 2022

Conversation

langz
Copy link
Contributor

@langz langz commented Apr 1, 2022

Fixes the following warning when running yarn build:types:

✖ The property "enable_body_lock" is not defined in PropTypes!
Component: Dropdown
File: ./src/components/dropdown/Dropdown.js


✖ The property "min_height" is not defined in PropTypes!
Component: Dropdown
File: ./src/components/dropdown/Dropdown.js


✖ The property "page_offset" is not defined in PropTypes!
Component: Dropdown
File: ./src/components/dropdown/Dropdown.js


✖ The property "observer_element" is not defined in PropTypes!
Component: Dropdown
File: ./src/components/dropdown/Dropdown.js

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9d2541:

Sandbox Source
eufemia-starter Configuration

@langz langz force-pushed the fix/missing-properties-in-proptypes-of-dropdown branch 2 times, most recently from fb88fb7 to 46ebcf3 Compare April 6, 2022 08:20
@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 6, 2022 •
edited
Loading

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 10m

Performance

Lighthouse report

Metric Score
Performance 🔶 67
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@langz langz force-pushed the fix/missing-properties-in-proptypes-of-dropdown branch 2 times, most recently from a99fadb to 4215931 Compare April 6, 2022 08:46
@langz
Copy link
Contributor Author

langz commented Apr 6, 2022 •
edited
Loading

Something wrong with the visual tests here.
Not able to reproduce the same failing test locally, it runs the visual tests successfully.
So not really sure what to do with this 🤔

Is this something you can help out with when you get time @tujoworker ?

@langz langz force-pushed the fix/missing-properties-in-proptypes-of-dropdown branch from 4215931 to bd10214 Compare April 25, 2022 07:55
@langz langz force-pushed the fix/missing-properties-in-proptypes-of-dropdown branch from bd10214 to 88ae6d2 Compare May 3, 2022 12:52
@langz langz requested a review from tujoworker May 4, 2022 08:59
@tujoworker tujoworker force-pushed the fix/missing-properties-in-proptypes-of-dropdown branch from 88ae6d2 to a9d2541 Compare May 9, 2022 21:05
@tujoworker
Copy link
Member

Sorry for the late reply. I think we may try to move the prop types over to the helpers instead of adding them directly to the component.
With that, the error messages/warnings are gone as well.
I made a quick commit to see if that helps when running on CI.

tujoworker
tujoworker approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You for taking care of these warnings ❤️

@langz
Copy link
Contributor Author

langz commented May 10, 2022 •
edited
Loading

Thanks for the great fix/improvement 🙏

@langz langz merged commit 7a83b38 into main May 10, 2022
@langz langz deleted the fix/missing-properties-in-proptypes-of-dropdown branch May 10, 2022 12:33
tujoworker pushed a commit that referenced this pull request Jun 23, 2022
@semantic-release-bot
chore(release): 9.27.0 [skip ci]
dd92cbe 
# [9.27.0](v9.26.1...v9.27.0) (2022-06-23)

### Bug Fixes

* always hide content from DOM when Accordion is collapsed ([41cbd9b](41cbd9b))
* **Autocomplete:** enhance VoiceOver support ([#1472](#1472)) ([f469dd8](f469dd8))
* **Autocomplete:** ensure "no options" is read out in aria-live ([#1471](#1471)) ([254303f](254303f))
* **Autocomplete:** fix using tab + write issue ([#1473](#1473)) ([73f9655](73f9655))
* **Autocomplete:** make VoiceOver announce first if a certain item is selected ([#1479](#1479)) ([d32e980](d32e980))
* **Autocomplete:** touch device issue on first focus ([#1476](#1476)) ([5fcbf17](5fcbf17))
* **Avatar:** properly handle spacing props ([5841990](5841990))
* **Breadcrumb:** properly handle spacing props ([b713dad](b713dad))
* **DatePicker:** make keyboard usage in input not throw ([#1475](#1475)) ([d0756e2](d0756e2))
* **DatePicker:** rename testing attributes to data-testid ([2e1e285](2e1e285))
* **Dialog:** fix Modal backdrop / overlay false-positive click issue while e.g. selecting ([#1463](#1463)) ([91e69a8](91e69a8))
* **Dialog:** fix Safari issue not able to scroll ([3f6fb31](3f6fb31))
* **Dialog:** make Dialog not overflow iOS Safari viewport ([764e487](764e487))
* **Dropdown:** Missing properties in PropTypes ([#1384](#1384)) ([7a83b38](7a83b38))
* **HeightAnimation:** ensure quick state changes to react without animating from start to finish ([886b4cd](886b4cd))
* **HelpButton:** Adds test when used inside texts ([#1404](#1404)) ([f8a7795](f8a7795))
* **Icon:** fix stopwatch icon (16px) ([d57c617](d57c617))
* **Input:** add missing Input test for icon and clear button ([#1465](#1465)) ([be2b4a0](be2b4a0))
* **Input:** enhance vertical centering for Safari (mainly iOS) ([#1469](#1469)) ([dadb5f8](dadb5f8))
* **InputMasked:** fix integerLimit option when used with decimals ([14fe5d9](14fe5d9))
* **Modal:** fix data-testid usage in object defined props ([e023f13](e023f13))
* **Modal:** fix flaky overlay opacity color issue happening in Chrome browser ([86d875d](86d875d))
* **Radio:** fix radio button disabled issue when inside of group ([#1477](#1477)) ([e775792](e775792))
* **Table:** align HTML/CSS classes and types ([ff0be8d](ff0be8d))
* **Table:** fix sticky Table when no offset is given ([888564d](888564d))
* **Table:** simplify sticky table hook ([f1e7e3b](f1e7e3b))
* **Tag:** properly handle spacing props ([d7129d8](d7129d8))
* **Timeline:** properly handle spacing props ([e823c6e](e823c6e))

### Features

* **Autocomplete:** add support for data suffix_value ([#1467](#1467)) ([fe6fbb7](fe6fbb7))
* **DatePicker:** add size property to component ([#1438](#1438)) ([749a118](749a118))
* **DrawerList:** use CSS Grid for placing list content to enhance flexibility ([#1470](#1470)) ([93fac6b](93fac6b))
* **Icons:** add calendar and bookmark icon ([#1449](#1449)) ([61c9c11](61c9c11))
* **Input:** add inner_element property for internal usage (as of now) ([#1466](#1466)) ([d1b1b19](d1b1b19))
* **MediaQuery:** convert to TypeScript ([1a23e4f](1a23e4f))
* **Modal:** add "bypass_invalidation_selectors" property to omit element invalidation ([d9cb392](d9cb392))
* **NumberFormat:** add srLabel property to enhance more easily a11y for screen reader users ([#1480](#1480)) ([004d675](004d675))
* **Provider:** rewrite to TypeScript ([#1436](#1436)) ([66416d9](66416d9))
* **Table:** change colors of table ([1f3687f](1f3687f))
* **Table:** move to components and rewrite to TypeScript ([562940a](562940a))
* **Timeline:** date supports a list of dates ([#1464](#1464)) ([a5c1dcd](a5c1dcd))
* **Timeline:** rename name to title & date to subtitle with backwards compatibility ([#1468](#1468)) ([6607963](6607963))
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tujoworker tujoworker tujoworker approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langz @tujoworker