Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MultiInputMask): incorrect legend hover and focus within effect #2861

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Nov 7, 2023

Proposal to fix the incorrect input hover effects when hovering over the legend element the .dnb-input__shell focus-within trigger, caused by the fakeBorder-mixin applying a inset to the box-shadow style.

Before:
Screenshot 2023-11-07 at 14 11 33
Screenshot 2023-11-07 at 14 11 46

After:
Screenshot 2023-11-07 at 14 11 02
Screenshot 2023-11-07 at 14 12 12

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 1:48pm

@joakbjerk joakbjerk force-pushed the fix/multi-input-mask-label-field-highlight branch from bf0542d to d57d29f Compare November 7, 2023 13:16
@joakbjerk joakbjerk requested review from tujoworker and langz November 7, 2023 13:18
@joakbjerk joakbjerk marked this pull request as ready for review November 7, 2023 13:18
Copy link

codesandbox-ci bot commented Nov 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a69f52a:

Sandbox Source
eufemia-starter Configuration

@joakbjerk joakbjerk merged commit 1cd6be4 into main Nov 7, 2023
10 checks passed
@joakbjerk joakbjerk deleted the fix/multi-input-mask-label-field-highlight branch November 7, 2023 14:09
tujoworker pushed a commit that referenced this pull request Nov 7, 2023
## [10.12.0](v10.11.0...v10.12.0) (2023-11-07)

### ✨ Features

* **MultiInputMask:** add support for multiple inputs ([#2736](#2736)) ([099c823](099c823))
* **useTheme:** return boolean constants: isUi, isSbanken and isEiendom ([#2845](#2845)) ([d3bb9be](d3bb9be))

### 📝 Documentation

* fix heading evels in contribution guide ([e67a05a](e67a05a))
* fix heading levels in contribution guide ([#2853](#2853)) ([4c01854](4c01854))
* **Theme:** enhance info about using the shared theme provider ([#2860](#2860)) ([dec0664](dec0664))

### 🐛 Bug Fixes

* **Button:** element's type supports Link of react-router-dom ([#2858](#2858)) ([b90acdb](b90acdb))
* **DrawerList:** Add focus style for Sbanken theme ([#2856](#2856)) ([1815342](1815342))
* **FormLabel:** move hover color logic to act on properties forId and onClick ([#2848](#2848)) ([43723ab](43723ab))
* **MultiInputMask:** incorrect legend hover and focus within effect ([#2861](#2861)) ([1cd6be4](1cd6be4))
* **PaymentCard:** overlay icon fill color ([#2846](#2846)) ([712a227](712a227))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants