Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MultiInputMask): add support for multiple inputs #2736

Merged
merged 70 commits into from
Nov 6, 2023

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Oct 9, 2023

The idea is that this addition to InputMasked will remove the need for all the custom code for the Expiry component and maybe the DatePickerInput also.

  • Come up with a better name than SteppedMask
  • Fix styling
  • Integrate useHandleCursorPosition hook
  • Documentation(?)
  • Write tests
  • Forward the correct HTML props and so on
  • Fine tune letter input handling
  • Add status props
  • Type documentation

The rationale for the naming is that this is a component with multiple masks/steps. Feel free to suggest a better name please 🙏

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 9:45am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 01f3bf2:

Sandbox Source
eufemia-starter Configuration

@tujoworker tujoworker changed the title Chore(InputMasked): add support for multiple inputs chore(InputMasked): add support for multiple inputs Oct 12, 2023
joakbjerk and others added 10 commits November 2, 2023 10:33
Co-authored-by: Tobias Høegh <tobias@tujo.no>
Co-authored-by: Tobias Høegh <tobias@tujo.no>
Co-authored-by: Tobias Høegh <tobias@tujo.no>
Co-authored-by: Tobias Høegh <tobias@tujo.no>
Co-authored-by: Tobias Høegh <tobias@tujo.no>
Co-authored-by: Tobias Høegh <tobias@tujo.no>
@joakbjerk joakbjerk force-pushed the chore/input-masked-add-support-for-multiple-inputs branch from 0960bb9 to bd75ecc Compare November 2, 2023 09:33
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 🥇

@joakbjerk joakbjerk merged commit 099c823 into main Nov 6, 2023
@joakbjerk joakbjerk deleted the chore/input-masked-add-support-for-multiple-inputs branch November 6, 2023 10:56
tujoworker pushed a commit that referenced this pull request Nov 7, 2023
## [10.12.0](v10.11.0...v10.12.0) (2023-11-07)

### ✨ Features

* **MultiInputMask:** add support for multiple inputs ([#2736](#2736)) ([099c823](099c823))
* **useTheme:** return boolean constants: isUi, isSbanken and isEiendom ([#2845](#2845)) ([d3bb9be](d3bb9be))

### 📝 Documentation

* fix heading evels in contribution guide ([e67a05a](e67a05a))
* fix heading levels in contribution guide ([#2853](#2853)) ([4c01854](4c01854))
* **Theme:** enhance info about using the shared theme provider ([#2860](#2860)) ([dec0664](dec0664))

### 🐛 Bug Fixes

* **Button:** element's type supports Link of react-router-dom ([#2858](#2858)) ([b90acdb](b90acdb))
* **DrawerList:** Add focus style for Sbanken theme ([#2856](#2856)) ([1815342](1815342))
* **FormLabel:** move hover color logic to act on properties forId and onClick ([#2848](#2848)) ([43723ab](43723ab))
* **MultiInputMask:** incorrect legend hover and focus within effect ([#2861](#2861)) ([1cd6be4](1cd6be4))
* **PaymentCard:** overlay icon fill color ([#2846](#2846)) ([712a227](712a227))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants