fix(Button): element's type supports Link of react-router-dom #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 66ee611:
|
Merged
langz
commented
Nov 6, 2023
langz
force-pushed
the
fix/support-link-from-react-router-dom
branch
from
9b3f924 to
66ee611
Compare
tujoworker
approved these changes
Nov 7, 2023
langz
changed the title
tujoworker
pushed a commit
that referenced
this pull request
Nov 7, 2023
## [10.12.0](v10.11.0...v10.12.0) (2023-11-07) ### ✨ Features * **MultiInputMask:** add support for multiple inputs ([#2736](#2736)) ([099c823](099c823)) * **useTheme:** return boolean constants: isUi, isSbanken and isEiendom ([#2845](#2845)) ([d3bb9be](d3bb9be)) ### 📝 Documentation * fix heading evels in contribution guide ([e67a05a](e67a05a)) * fix heading levels in contribution guide ([#2853](#2853)) ([4c01854](4c01854)) * **Theme:** enhance info about using the shared theme provider ([#2860](#2860)) ([dec0664](dec0664)) ### 🐛 Bug Fixes * **Button:** element's type supports Link of react-router-dom ([#2858](#2858)) ([b90acdb](b90acdb)) * **DrawerList:** Add focus style for Sbanken theme ([#2856](#2856)) ([1815342](1815342)) * **FormLabel:** move hover color logic to act on properties forId and onClick ([#2848](#2848)) ([43723ab](43723ab)) * **MultiInputMask:** incorrect legend hover and focus within effect ([#2861](#2861)) ([1cd6be4](1cd6be4)) * **PaymentCard:** overlay icon fill color ([#2846](#2846)) ([712a227](712a227))
|
🎉 This PR is included in version 10.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a "quick fix", making it possible in TypeScript to send
Linkof react-router-dom as a value to theelementprop.This possibility was removed as part of e030657
I'm not 100% sure about this fix(as I've just reverted(added back
any) from this e030657#diff-ece10293b585707067686d660cf459378b2027585fc414e1263e9694b0ed0be2L38First reported here: https://dnb-it.slack.com/archives/CMXABCHEY/p1699274667145269
I think/hope we could release this as part of v10.11.1(or v10.12.0?), as the reporters are eager for a fix 🙏
Seems like the "problem" was introduced in v10.10.0, should we also try making a release v10.10.1 for this, or is that too much work perhaps? 🤔