feat(VisuallyHidden): Add VisuallyHidden component #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaytharma
force-pushed
the
feat/visually-hidden
branch
from
2faaba6 to
14c3b41
Compare
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 10m PerformanceLighthouse report
|
thaytharma
changed the title
thaytharma
force-pushed
the
feat/visually-hidden
branch
from
14c3b41 to
fecbaf4
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9f53f0:
|
thaytharma
force-pushed
the
feat/visually-hidden
branch
from
fecbaf4 to
77d7f04
Compare
tujoworker
approved these changes
Feb 7, 2022
| * Root element of the component | ||
| * Default: div | ||
| */ | ||
| element?: string |
There was a problem hiding this comment.
Maybe use ReactNode here? This way its even possible to send in an existing component.
const Component = () => <div>...</div>
render(<VisuallyHidden element={Component}>hidden content</VisuallyHidden>)There was a problem hiding this comment.
Great suggestion!
This has been updated 🚀
thaytharma
force-pushed
the
feat/visually-hidden
branch
from
77d7f04 to
f9f53f0
Compare
tujoworker
pushed a commit
that referenced
this pull request
Feb 9, 2022
# [9.22.0](v9.21.0...v9.22.0) (2022-02-09) ### Bug Fixes * **Avatar:** make the radius 100% round ([06e4133](06e4133)) * avoid Modal (dialog) from being omitted in accessibility tree ([#1205](#1205)) ([1d4d6f1](1d4d6f1)) * fix InputMasked delete key usage ([0e13054](0e13054)), closes [#1113](#1113) * **Icons:** fix svgo config ([e9326ee](e9326ee)) * **Icons:** lower icon size ([5e86696](5e86696)) * **Logo:** center logo in bounding box by using flex ([2a9eed7](2a9eed7)) * **Modal:** ensure IE11 is placing the close button to the right side ([1aab80f](1aab80f)) * **Modal:** make revalidation after Modal close work on IE11 ([c00c489](c00c489)) * **NumberUtils:** enhance missing types ([5e46814](5e46814)) * **NumberUtils:** fix IE11 issue with ([6225b9a](6225b9a)) ### Features * **Tabs:** add no_border prop ([#1279](#1279)) ([47826fd](47826fd)) * update icons: credit_note, deleted_invoice, speedometer, travel ([3b91772](3b91772)) * **Version:** run Eufemia.version in your browser console ([06e8658](06e8658)) * **VisuallyHidden:** Add VisuallyHidden component ([#1246](#1246)) ([48819d4](48819d4))
|
🎉 This PR is included in version 9.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
VisuallyHidden-componentI started with using
dnb-sr-only-class, but ended up using the thesrOnly-mixin instead as I felt it was a "cleaner".I also added a
focusable-option which I saw being used in other libraries like in BootstrapI'm open to suggestions as this is an initial version of the component 😊