Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tabs): add no_border prop which removes tablist border #1279

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

thaytharma
Copy link
Contributor

Added no_border-prop to remove the default bottom border under the tablist.

@thaytharma thaytharma requested a review from tujoworker February 8, 2022 15:46
@thaytharma thaytharma mentioned this pull request Feb 8, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2161f12:

Sandbox Source
eufemia-starter Configuration

@thaytharma thaytharma changed the title feat(Tabs): add no_border prop feat(Tabs): add no_border prop which removes tablist border Feb 8, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 8, 2022

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 11m

Performance

Lighthouse report

Metric Score
Performance 🔶 68
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! ✨🤩

@thaytharma thaytharma merged commit 47826fd into main Feb 8, 2022
@thaytharma thaytharma deleted the feat/tabs-border branch February 8, 2022 17:35
tujoworker pushed a commit that referenced this pull request Feb 9, 2022
# [9.22.0](v9.21.0...v9.22.0) (2022-02-09)

### Bug Fixes

* **Avatar:** make the radius 100% round ([06e4133](06e4133))
* avoid Modal (dialog) from being omitted in accessibility tree ([#1205](#1205)) ([1d4d6f1](1d4d6f1))
* fix InputMasked delete key usage ([0e13054](0e13054)), closes [#1113](#1113)
* **Icons:** fix svgo config ([e9326ee](e9326ee))
* **Icons:** lower icon size ([5e86696](5e86696))
* **Logo:** center logo in bounding box by using flex ([2a9eed7](2a9eed7))
* **Modal:** ensure IE11 is placing the close button to the right side ([1aab80f](1aab80f))
* **Modal:** make revalidation after Modal close work on IE11 ([c00c489](c00c489))
* **NumberUtils:** enhance missing types ([5e46814](5e46814))
* **NumberUtils:** fix IE11 issue with ([6225b9a](6225b9a))

### Features

* **Tabs:** add no_border prop ([#1279](#1279)) ([47826fd](47826fd))
* update icons: credit_note, deleted_invoice, speedometer, travel ([3b91772](3b91772))
* **Version:** run Eufemia.version in your browser console ([06e8658](06e8658))
* **VisuallyHidden:** Add VisuallyHidden component ([#1246](#1246)) ([48819d4](48819d4))
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants