fix: add external link icon to anchor with element as children #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1c373e9:
|
joakbjerk
commented
Jul 7, 2023
There was a problem hiding this comment.
Allowing element as children whilst also showing the external link button seems to have changed the screenshot test, not sure if this change is acceptable?
tujoworker
changed the title
|
Nice! A jest test that confirms the changes would be good to have 🙏 |
tujoworker
force-pushed
the
chore/anchor-enable-suffix-icon-when-component-is-used-for-text
branch
from
d2da371 to
e29b15b
Compare
tujoworker
force-pushed
the
chore/anchor-enable-suffix-icon-when-component-is-used-for-text
branch
from
e29b15b to
0d665a6
Compare
tujoworker
approved these changes
Aug 31, 2023
joakbjerk
force-pushed
the
chore/anchor-enable-suffix-icon-when-component-is-used-for-text
branch
from
6fecedb to
4aa7769
Compare
joakbjerk
force-pushed
the
chore/anchor-enable-suffix-icon-when-component-is-used-for-text
branch
from
4aa7769 to
97a7d7a
Compare
joakbjerk
deleted the
chore/anchor-enable-suffix-icon-when-component-is-used-for-text
branch
tujoworker
pushed a commit
that referenced
this pull request
Sep 6, 2023
## [10.8.0](v10.7.0...v10.8.0) (2023-09-06) ### 📝 Documentation * **NumberFormat:** add source for number formatting in documentation ([#2596](#2596)) ([74415a9](74415a9)) * **Section:** move deprecated styles into a seperate docs page ([#2585](#2585)) ([d36a4fb](d36a4fb)), closes [#2582](#2582) * **StepIndicator:** fix link to drawer docs ([#2593](#2593)) ([31c17eb](31c17eb)) ### ✨ Features * **Accordion:** sbanken theme ([#2586](#2586)) ([90cc4ac](90cc4ac)) * **Breadcrumb:** Add Sbanken style ([#2601](#2601)) ([8efbf4a](8efbf4a)) * **Checkbox:** add innerRef prop to link a React Ref to the input element ([#2595](#2595)) ([095ee6d](095ee6d)) * **Forms:** improvements ([#2603](#2603)) ([2a86a4a](2a86a4a)) * **FormStatus:** Add Sbanken styles ([#2605](#2605)) ([79dfaee](79dfaee)) * **GlobalStatus:** Add warning and success states and Sbanken style ([#2584](#2584)) ([33ba995](33ba995)) * **Radio:** add innerRef prop to link a React Ref to the input element ([#2598](#2598)) ([348ad80](348ad80)) * **Switch:** add innerRef prop to link a React Ref to the input element ([#2597](#2597)) ([efa7733](efa7733)) * **Typography, Heading:** change font sizes and added small screen sizes for sbanken ([#2599](#2599)) ([96974ab](96974ab)) ### 🐛 Bug Fixes * add external link icon to anchor with element as children ([#2520](#2520)) ([2566dae](2566dae)) * **Autocomplete:** make independent_width work properly ([#2589](#2589)) ([90cfc58](90cfc58)) * **Drawer:** add support for closeButtonAttributes ([#2616](#2616)) ([d01d2fe](d01d2fe)) * **Drawer:** render Drawer.Navigation when hideCloseButton is true ([#2613](#2613)) ([fb8b031](fb8b031)) * **Forms:** align card border ([#2588](#2588)) ([cd5f695](cd5f695)), closes [#2587](#2587) * **Forms:** make PhoneNumber country code searchable by numbers ([#2590](#2590)) ([6bdb62f](6bdb62f)) * **Forms:** use rem unit over px ([#2587](#2587)) ([fe9aee4](fe9aee4)) * **InputMasked:** ensure a value with null does not remove the placeholder ([#2594](#2594)) ([3d13453](3d13453)) * **MaskedInput:** correct keep_placeholder css selector ([#2608](#2608)) ([509c740](509c740)) * **TimeLine:** make it possible to update state of subtitle from another subtitle ([#2600](#2600)) ([50302dd](50302dd))
|
🎉 This PR is included in version 10.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to make the external link icon show up inside
Anchorifchildrenis set to be anElement.This change does however require developers to set the styling of the child to have some sort of
inlinedisplay to not throw off/break the icon and tooltip alignment, but this might be a non issue.See examples provided in screenshot below
