Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormStatus): Add Sbanken styles #2605

Merged
merged 11 commits into from
Sep 5, 2023
Merged

Conversation

Sundfjord
Copy link
Contributor

Added Sbanken styles to match color scheme present in GlobalStatus/Section components.

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 8:42am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9382555:

Sandbox Source
eufemia-starter Configuration

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👌 I just have some question and one formatting suggestion 🙏

@@ -6,11 +6,19 @@ import {
} from '@dnb/eufemia/src/components/form-status/FormStatus'

## Use the [**FormStatus**](/uilib/components/form-status) icons only
<VisibilityByTheme hidden="sbanken">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the formatting. A newline between each new content type would be good. Also, when running prettier, it should remove two newlines to one.

@tujoworker tujoworker force-pushed the feat/formstatus-sbanken-styling branch from 889e02c to 7e43303 Compare September 4, 2023 12:57
@Sundfjord Sundfjord merged commit 79dfaee into main Sep 5, 2023
@Sundfjord Sundfjord deleted the feat/formstatus-sbanken-styling branch September 5, 2023 09:31
tujoworker pushed a commit that referenced this pull request Sep 6, 2023
## [10.8.0](v10.7.0...v10.8.0) (2023-09-06)

### 📝 Documentation

* **NumberFormat:** add source for number formatting in documentation ([#2596](#2596)) ([74415a9](74415a9))
* **Section:** move deprecated styles into a seperate docs page ([#2585](#2585)) ([d36a4fb](d36a4fb)), closes [#2582](#2582)
* **StepIndicator:** fix link to drawer docs ([#2593](#2593)) ([31c17eb](31c17eb))

### ✨ Features

* **Accordion:** sbanken theme ([#2586](#2586)) ([90cc4ac](90cc4ac))
* **Breadcrumb:** Add Sbanken style ([#2601](#2601)) ([8efbf4a](8efbf4a))
* **Checkbox:** add innerRef prop to link a React Ref to the input element ([#2595](#2595)) ([095ee6d](095ee6d))
* **Forms:** improvements ([#2603](#2603)) ([2a86a4a](2a86a4a))
* **FormStatus:** Add Sbanken styles ([#2605](#2605)) ([79dfaee](79dfaee))
* **GlobalStatus:** Add warning and success states and Sbanken style ([#2584](#2584)) ([33ba995](33ba995))
* **Radio:** add innerRef prop to link a React Ref to the input element ([#2598](#2598)) ([348ad80](348ad80))
* **Switch:** add innerRef prop to link a React Ref to the input element ([#2597](#2597)) ([efa7733](efa7733))
* **Typography, Heading:** change font sizes and added small screen sizes for sbanken ([#2599](#2599)) ([96974ab](96974ab))

### 🐛 Bug Fixes

* add external link icon to anchor with element as children ([#2520](#2520)) ([2566dae](2566dae))
* **Autocomplete:** make independent_width work properly ([#2589](#2589)) ([90cfc58](90cfc58))
* **Drawer:** add support for closeButtonAttributes ([#2616](#2616)) ([d01d2fe](d01d2fe))
* **Drawer:** render Drawer.Navigation when hideCloseButton is true ([#2613](#2613)) ([fb8b031](fb8b031))
* **Forms:** align card border ([#2588](#2588)) ([cd5f695](cd5f695)), closes [#2587](#2587)
* **Forms:** make PhoneNumber country code searchable by numbers ([#2590](#2590)) ([6bdb62f](6bdb62f))
* **Forms:** use rem unit over px ([#2587](#2587)) ([fe9aee4](fe9aee4))
* **InputMasked:** ensure a value with null does not remove the placeholder ([#2594](#2594)) ([3d13453](3d13453))
* **MaskedInput:** correct keep_placeholder css selector ([#2608](#2608)) ([509c740](509c740))
* **TimeLine:** make it possible to update state of subtitle from another subtitle ([#2600](#2600)) ([50302dd](50302dd))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants