chore(Icon): adds test for when icon provided is FC using hooks #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
langz
commented
Jun 12, 2024
•
langz
commented
- Added a test case
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
langz
changed the title
|
For fun, I checked if this test worked in #3703, and it does, so that's great. |
langz
changed the title
langz
force-pushed
the
fix/hooks-error-using-form-status-icons-in-icon
branch
from
937860f to
d961d95
Compare
langz
force-pushed
the
fix/hooks-error-using-form-status-icons-in-icon
branch
2 times, most recently
from
d2ced20 to
c005ecd
Compare
tujoworker
force-pushed
the
feat/icon-typescript
branch
from
1dfec8c to
01beba3
Compare
tujoworker
added a commit
that referenced
this pull request
Jun 13, 2024
Will solve the issue described in this PR #3699 Even all the tests and types are running green, it needs extensive manual testing. --------- Co-authored-by: Anders <anderslangseth@gmail.com>
langz
force-pushed
the
fix/hooks-error-using-form-status-icons-in-icon
branch
from
c005ecd to
ff5f10a
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
pushed a commit
that referenced
this pull request
Jun 14, 2024
## [10.36.0](v10.35.0...v10.36.0) (2024-06-14) ### ✨ Features * **Anchor:** add helper classes as props ([#3701](#3701)) ([62b23e8](62b23e8)) * **forms:** add `activeWhen` prop to Wizard.Step ([#3705](#3705)) ([edd6214](edd6214)) * **Icon:** rewrite to TypeScript and hooks ([#3703](#3703)) ([70b1f8b](70b1f8b)), closes [#3699](#3699) * **Table:** refactoring of types, documentation, and accordion file structure ([#3683](#3683)) ([6045e42](6045e42)) ### 🐛 Bug Fixes * **Autocomplete:** make `input_value` react to prop change ([#3706](#3706)) ([641e5e7](641e5e7)) * **Autocomplete:** make inputValue update on data prop changes ([#3581](#3581)) ([83b05cf](83b05cf)) * **forms:** ensure useReactRouter to handle initial data given by url ([#3708](#3708)) ([a16f1f7](a16f1f7)), closes [#3702](#3702) * **StepIndicator:** avoid re-assigning functions that can cause titles to be not in sync ([#3697](#3697)) ([d8d740c](d8d740c)), closes [#3685](#3685) ### 📝 Documentation * **forms:** add translations table ([#3693](#3693)) ([84605b7](84605b7)) * **Tabs:** fix the title of Tabs breakout example ([#3696](#3696)) ([7747e06](7747e06)) * **Tabs:** improve property docs ([#3665](#3665)) ([7849cba](7849cba)) * update grid layout example without responsive sidebar ([#3709](#3709)) ([f4363c2](f4363c2))
|
🎉 This PR is included in version 10.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.