Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): ensure useReactRouter to handle initial data given by url #3708

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix(forms): ensure useReactRouter to handle initial data given by url #3708

merged 1 commit into from
Jun 14, 2024

Conversation

tujoworker
Copy link
Member

Fixes #3702

@tujoworker tujoworker requested a review from joakbjerk June 14, 2024 09:13
@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 9:20am

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker requested a review from langz June 14, 2024 10:38
@tujoworker tujoworker mentioned this pull request Jun 14, 2024
Merged
5 tasks
langz
langz approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried reproducing the issue with your fix in this CSB, and I was not able to reproduce the error reported in this CSB when refreshing.

So I'd say this fix works 🥳 🎆

@tujoworker
Copy link
Member Author

jepp, all the tests I added to fail with the same exception if the fix is not applied.

@tujoworker tujoworker merged commit a16f1f7 into main Jun 14, 2024
15 checks passed
@tujoworker tujoworker deleted the fix/wizard-useReactRouter branch June 14, 2024 10:57
@tujoworker
Copy link
Member Author

I tried reproducing the issue with your fix in this CSB, and I was not able to reproduce the error reported in this CSB when refreshing.

So I'd say this fix works 🥳 🎆

Thank you for checking it out 🙏

tujoworker added a commit that referenced this pull request Jun 14, 2024
@tujoworker
release of v10.36 (#3707)
b999dd1 
Get inn these PRs:

- [x] #3706
- [x] #3581
- [x] #3683
- [x] #3709
- [x] #3708
tujoworker pushed a commit that referenced this pull request Jun 14, 2024
@semantic-release-bot
chore(release): 10.36.0 [skip ci]
7c6fe4c 
## [10.36.0](v10.35.0...v10.36.0) (2024-06-14)

### ✨ Features

* **Anchor:** add helper classes as props ([#3701](#3701)) ([62b23e8](62b23e8))
* **forms:** add `activeWhen` prop to Wizard.Step ([#3705](#3705)) ([edd6214](edd6214))
* **Icon:** rewrite to TypeScript and hooks ([#3703](#3703)) ([70b1f8b](70b1f8b)), closes [#3699](#3699)
* **Table:** refactoring of types, documentation, and accordion file structure ([#3683](#3683)) ([6045e42](6045e42))

### 🐛 Bug Fixes

* **Autocomplete:** make `input_value` react to prop change ([#3706](#3706)) ([641e5e7](641e5e7))
* **Autocomplete:** make inputValue update on data prop changes ([#3581](#3581)) ([83b05cf](83b05cf))
* **forms:** ensure useReactRouter to handle initial data given by url ([#3708](#3708)) ([a16f1f7](a16f1f7)), closes [#3702](#3702)
* **StepIndicator:** avoid re-assigning functions that can cause titles to be not in sync ([#3697](#3697)) ([d8d740c](d8d740c)), closes [#3685](#3685)

### 📝 Documentation

* **forms:** add translations table ([#3693](#3693)) ([84605b7](84605b7))
* **Tabs:** fix the title of Tabs breakout example ([#3696](#3696)) ([7747e06](7747e06))
* **Tabs:** improve property docs ([#3665](#3665)) ([7849cba](7849cba))
* update grid layout example without responsive sidebar ([#3709](#3709)) ([f4363c2](f4363c2))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz approved these changes

@joakbjerk joakbjerk Awaiting requested review from joakbjerk

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reloading Form Step with useReactRouter causes setActiveIndex is not a function error
2 participants
@tujoworker @langz