feat(Forms): add Form.Card with different default appearance than Card (use Form.Card in forms instead of Card)
#4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
changed the title
Form.Card with different default appearance than CardForm.Card with different default appearance than Card (use Form.Card in forms instead of Card)
langz
approved these changes
Nov 21, 2024
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Form/Card.mdx
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
tujoworker
force-pushed
the
feat/forms-card
branch
from
8e86b7c to
5c4b536
Compare
tujoworker
force-pushed
the
feat/forms-card
branch
from
5c4b536 to
76524be
Compare
Co-authored-by: Anders <anderslangseth@gmail.com>
tujoworker
force-pushed
the
feat/forms-card
branch
from
76524be to
4fa1102
Compare
tujoworker
force-pushed
the
feat/forms-card
branch
from
4fa1102 to
e00633a
Compare
langz
reviewed
Nov 22, 2024
packages/dnb-design-system-portal/src/docs/uilib/components/card/demos.mdx
Outdated
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
packages/dnb-design-system-portal/src/docs/uilib/components/card/demos.mdx
Outdated
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
packages/dnb-design-system-portal/src/docs/uilib/components/card/demos.mdx
Outdated
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
packages/dnb-design-system-portal/src/docs/uilib/components/card/demos.mdx
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
...design-system-portal/src/docs/uilib/extensions/forms/Form/Section/EditContainer/Examples.tsx
Outdated
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
...-design-system-portal/src/docs/uilib/extensions/forms/Iterate/AnimatedContainer/Examples.tsx
Outdated
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Value/Provider/Examples.tsx
Outdated
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
...ages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Value/SummaryList/Examples.tsx
Outdated
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
packages/dnb-eufemia/src/extensions/forms/Wizard/style/dnb-wizard-layout.scss
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
tujoworker
force-pushed
the
feat/forms-card
branch
from
e26dd3a to
b34469d
Compare
langz
reviewed
Nov 22, 2024
packages/dnb-design-system-portal/src/docs/uilib/about-the-lib/releases/eufemia/v11-info.mdx
Show resolved
Hide resolved
Yes.
No –
We still have some for the card component. I think we have covered what we need to cover. |
tujoworker
force-pushed
the
feat/forms-card
branch
from
b34469d to
441616c
Compare
tujoworker
pushed a commit
that referenced
this pull request
Nov 22, 2024
## [10.57.0](v10.56.0...v10.57.0) (2024-11-22) ### 📝 Documentation * **Field.Upload:** adds `asyncFileHandler` property ([#4288](#4288)) ([fb09758](fb09758)) * **Field.Upload:** adds asyncFileHandler property ([7ccdabd](7ccdabd)) ### 🐛 Bug Fixes * **Forms:** align Value.SummaryList when Value.* has no label ([#4311](#4311)) ([b6621c2](b6621c2)) * **Forms:** ensure fields inside composition share submit indicator ([#4309](#4309)) ([e726e20](e726e20)) * **Forms:** safeguard errorMessages to avoid infinite loops when not wrapped in useMemo ([#4305](#4305)) ([f14bacc](f14bacc)) * **Forms:** show indicator with async onBlurValidator call when `validateInitially` is used ([#4303](#4303)) ([c585491](c585491)) * **Icon:** ensure icon name is rendered as `data-testid` ([#4304](#4304)) ([235b823](235b823)) ### ✨ Features * **Card, Section:** add `outset` property for moderate layout breakout ([#4317](#4317)) ([6008d9a](6008d9a)) * **DrawerList, Dropdown, Autocomplete, Field.Selection, Field.ArraySelection:** disabled options ([#4154](#4154)) ([8786d5d](8786d5d)) * **Field.Upload:** adds support for async and sync fn in `fileHandler` ([#4294](#4294)) ([2cc816a](2cc816a)) * **Forms:** add `Form.Card` with different default appearance than Card (use `Form.Card` in forms instead of Card) ([#4318](#4318)) ([7bbc0ca](7bbc0ca)) * **Forms:** add `labelSrOnly` to Value.* components ([#4319](#4319)) ([46f68ae](46f68ae)), closes [#4311](#4311) * **Forms:** deprecate `validator` in favor of `onChangeValidator` ([#4314](#4314)) ([5a06b2e](5a06b2e)) * **Typography:** add general `.dnb-t` helper classes and add typography props to Span ([#4235](#4235)) ([9dfe66d](9dfe66d))
|
🎉 This PR is included in version 10.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we introduce
Form.Carda new wrapper component for Card. It defaults to true onoutsetandstack. So when using it, it automatically gives the needed styles for classical forms.Here are the docs.
We also need to set a higher gap between the Wizard sidebar and its content: