인증/인가 파트 리팩토링 #52
Merged
인증/인가 파트 리팩토링 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 79 files 79 suites 6s ⏱️ Results for commit 5ef30e0. ♻️ This comment has been updated with latest results. |
woo0doo
approved these changes
Mar 31, 2024
| public ApiResponse<TokensResponseDto> loginKakao(@RequestParam String code, HttpServletResponse response) throws JsonProcessingException { | ||
| Token tokens = kakaoService.loginKakao(code); | ||
| ResponseCookie cookie = ResponseCookie.from(REFRESH_TOKEN, tokens.refreshToken()) | ||
| .maxAge(60*60*24*7) |
| private final static String REFRESH_TOKEN = "refreshToken"; | ||
|
|
||
| @PostMapping("/signup") | ||
| public ApiResponse<TokensResponseDto> signUpUser(@RequestBody @Valid SignUpRequestDto signUpRequestDto, HttpServletResponse response) { | ||
| Token tokens = userService.signUpUser(signUpRequestDto); | ||
| ResponseCookie cookie = ResponseCookie.from(REFRESH_TOKEN, tokens.refreshToken()) | ||
| .maxAge(REFRESH_TOKEN_EXPIRE_TIME) | ||
| .maxAge(60*60*24*7) |
There was a problem hiding this comment.
네 이것 때문에 ㅠㅠ.. 로컬에서는 정상 작동하는데..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📕 연관 이슈 번호
#45
📙 작업 내용
📗 논의 사항
📘 체크리스트