Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

인증/인가 파트 리팩토링 #52

Merged
merged 14 commits into from
Mar 31, 2024
Merged

인증/인가 파트 리팩토링 #52

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d67112e
feat : 유저 정보 수정하기 api에 @Valid 추가 #45
strangehoon Mar 4, 2024
8a3f079
refactor : jwt, 인증 예외 처리 필터 분리 #45
strangehoon Mar 4, 2024
8fbf976
refactor : jwt provider 수정 #45
strangehoon Mar 29, 2024
5128f22
Merge branch 'develop' into feature/#45
strangehoon Mar 29, 2024
289aea7
refactor : refresh token을 쿠키에 저장 #45
strangehoon Mar 30, 2024
9399dcf
fix : 빈 참조 에러 해결 #45
strangehoon Mar 30, 2024
5005694
test : refresh token 쿠키 저장으로 인한 test 일시 disabled 처리 #45
strangehoon Mar 30, 2024
a7ea993
fix : 빈 참조 에러 해결 #45
strangehoon Mar 30, 2024
8911605
chore : 잠깐 주석 처리 #45
strangehoon Mar 30, 2024
0dc0c53
chore : logback 잠시 삭제 #45
strangehoon Mar 30, 2024
b45857a
chore : jacoco 잠시 주석 처리 #45
strangehoon Mar 30, 2024
69f0028
refactor : refresh token 값 수정 #45
strangehoon Mar 30, 2024
62aee36
chore : refresh token 값 value 제거 #45
strangehoon Mar 30, 2024
5ef30e0
chore : 잠깐 테스트한 파일 주석 해제 #45
strangehoon Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/com/sendback/domain/auth/controller/AuthController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ public class AuthController {
private final KakaoService kakaoService;
private final GoogleService googleService;
private final AuthService authService;
@Value("${jwt.refresh-token-expire-time}")
private long REFRESH_TOKEN_EXPIRE_TIME;
private final static String REFRESH_TOKEN = "refreshToken";

@GetMapping("/kakao/callback")
Expand Down
4 changes: 1 addition & 3 deletions src/main/java/com/sendback/domain/user/controller/UserController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,13 @@
public class UserController {

private final UserService userService;
@Value("${jwt.refresh-token-expire-time}")
private long REFRESH_TOKEN_EXPIRE_TIME;
private final static String REFRESH_TOKEN = "refreshToken";

@PostMapping("/signup")
public ApiResponse<TokensResponseDto> signUpUser(@RequestBody @Valid SignUpRequestDto signUpRequestDto, HttpServletResponse response) {
Token tokens = userService.signUpUser(signUpRequestDto);
ResponseCookie cookie = ResponseCookie.from(REFRESH_TOKEN, tokens.refreshToken())
.maxAge(REFRESH_TOKEN_EXPIRE_TIME)
.maxAge(60*60*24*7)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것때문에 오류났던 거였나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 이것 때문에 ㅠㅠ.. 로컬에서는 정상 작동하는데..

.path("/")
.secure(true)
.sameSite("None")
Expand Down
Loading