Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer require contact_id to purchase LetsEncrypt certificates #46

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

ggalmazor
Copy link
Contributor

On this PR:

  • Deprecate contactId on Cetificate
  • Fix specs to show that we no longer need to pass a contact_id attribute to purchase LE certificates

@ggalmazor ggalmazor requested review from a team, OleMchls and dallasread and removed request for a team May 27, 2022 07:31
@ggalmazor ggalmazor self-assigned this May 27, 2022
@ggalmazor ggalmazor added enhancement ready-for-review Pull requests that are ready to be reviewed by other team members. labels May 27, 2022
@ggalmazor ggalmazor assigned ggalmazor and unassigned ggalmazor May 27, 2022
@ggalmazor ggalmazor requested review from DXTimer and jacegu and removed request for OleMchls and dallasread May 27, 2022 07:54
@jacegu jacegu requested review from a team, OleMchls and dallasread and removed request for a team May 27, 2022 11:51
@jacegu jacegu merged commit 5c302b9 into main Jun 1, 2022
@jacegu jacegu deleted the change/remove_contact_id_from_LE_cert_purchase branch June 1, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready-for-review Pull requests that are ready to be reviewed by other team members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants