Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer require contact_id to purchase LetsEncrypt certificates #46

Merged
merged 2 commits into from
Jun 1, 2022
Merged

No longer require contact_id to purchase LetsEncrypt certificates #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad9ea8
Change: show in the specs that we don't send the `contact_id` anymore
ggalmazor May 27, 2022
ec0dbd3
Change: deprecate the `contactId` field on `Certificate`
ggalmazor May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Dnsimple/Struct/Certificate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class Certificate
public $domainId;
/**
* @var int The associated contact ID
* @deprecated
*/
public $contactId;
/**
Expand Down
6 changes: 2 additions & 4 deletions tests/Dnsimple/Service/CertificatesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function testListCertificates()
public function testListCertificatesSupportsSorting()
{
$this->mockResponseWith("listCertificates/success");
$this->service->listCertificates(1010, "example.com", ["sort"=>"id:asc,common_name:desc,expiration:asc"]);
$this->service->listCertificates(1010, "example.com", ["sort" => "id:asc,common_name:desc,expiration:asc"]);

self::assertEquals("sort=id%3Aasc%2Ccommon_name%3Adesc%2Cexpiration%3Aasc", $this->queryContent());
}
Expand Down Expand Up @@ -109,9 +109,7 @@ public function testPurchaseLetsEncryptCertificate()
{
$this->mockResponseWith("purchaseLetsencryptCertificate/success");

$attributes = [
"contact_id" => 42
];
$attributes = [];
$certificatePurchase = $this->service->purchaseLetsEncryptCertificate(1010, "example.com", $attributes)->getData();

self::assertInstanceOf(CertificatePurchase::class, $certificatePurchase);
Expand Down