This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Volumes grpc interface #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
gtardif
force-pushed
the
volumes-grpc
branch
from
4f0f8db to
b2fac74
Compare
|
CI workflows need to be fixed to include build happening on fork (green now for this PR) |
gtardif
force-pushed
the
volumes-grpc
branch
from
b2fac74 to
0561e6b
Compare
|
This will require a follow up PR in node-sdk to add volumes API, and add a volume sample (already tested, working on ACI context) |
chris-crone
reviewed
Sep 28, 2020
gtardif
force-pushed
the
volumes-grpc
branch
3 times, most recently
from
88d9a85 to
4838da9
Compare
rumpl
reviewed
Sep 28, 2020
rumpl
reviewed
Sep 28, 2020
rumpl
reviewed
Sep 28, 2020
server/proxy/volumes.go
Outdated
| return nil, errors.Wrapf(errdefs.ErrNotImplemented, "volume API only available in ACI context") | ||
| } | ||
| aciReq := req.GetAciOption() | ||
| if aciReq == nil { |
There was a problem hiding this comment.
This check should be in the backend too no?
There was a problem hiding this comment.
Actually we need to read the gRPC param and convert it into params for the backend. We can just pass an empty storage account by default and let the backend return the error, that would avoid different errors for different code paths, yes.
gtardif
force-pushed
the
volumes-grpc
branch
from
4838da9 to
b74540c
Compare
…cific parameters, proxy volume creation Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
gtardif
force-pushed
the
volumes-grpc
branch
from
b74540c to
b9d6c2e
Compare
rumpl
reviewed
Sep 28, 2020
| @@ -36,9 +36,12 @@ var ( | |||
| "/com.docker.api.protos.containers.v1.Containers/Kill": "kill", | |||
| "/com.docker.api.protos.containers.v1.Containers/Inspect": "inspect", | |||
| "/com.docker.api.protos.containers.v1.Containers/Logs": "logs", | |||
| "/com.docker.api.protos.streams.v1.Streaming/NewStream": "", | |||
| "/com.docker.api.protos.streams.v1.Streaming/NewStream": "streaming", | |||
There was a problem hiding this comment.
I just didn't want to let this empty, if anyone calls this, we'll see something we can follow in the metrics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Replace #640 (including commit from @ulyssessouza) to follow up with things we did pair programming and fixes in metrics)
Related issue
#604
(not mandatory) A picture of a cute animal, if possible in relation with what you did