This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Update CI workflow to build fine on PRs from forks #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
gtardif
force-pushed
the
ci_fork_prs
branch
from
7e81e1d to
127baa3
Compare
|
Beware running optional tests (ACI/ECS) on a forked branch will only succeed if you have defined the relevant secrets in your fork, in order to login to ACI/ECS |
ndeloof
approved these changes
Sep 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Tardif guillaume.tardif@docker.com
What I did
Update workflow to run on PRs, and only on main branch (if on all branches, for every PR that would run one GH Action for the branch push on the fork, and one for the PR opening)
Related issue
Seen in #683 : build happens on push on forks, but the build notifications are not propagted to the PR
(not mandatory) A picture of a cute animal, if possible in relation with what you did
