This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] Bump Golang to 1.11.11 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @kolyshkin @andrewhsu @tiborvass PTAL |
|
SGTM |
tiborvass
approved these changes
Mar 12, 2019
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
805deea to
1718152
Compare
thaJeztah
changed the title
|
Looks like I can remove moby#37770, which was cherry-picked as part of #198 |
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
1718152 to
c619c0e
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
c619c0e to
372c5c7
Compare
thaJeztah
changed the title
|
Rebased, and bumped to Go 1.11.11 |
|
Hooray, since moby#37500 is there and go >= 1.10 those linker warnings for static binaries are gone! 🎆 |
This should eliminate a bunch of new (go-1.11 related) validation errors telling that the code is not formatted with `gofmt -s`. No functional change, just whitespace (i.e. `git show --ignore-space-change` shows nothing). Patch generated with: > git ls-files | grep -v ^vendor/ | grep .go$ | xargs gofmt -s -w Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 9b0097a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
To include the following backported fix: kolyshkin/ugorji-go@1cf431c13dec46596 which should fix this: > 13:40:53 vendor/github.com/ugorji/go/codec/gen-helper.generated.go:1: > possible malformed +build comment%!(EXTRA []interface {}=[]) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 09921ca) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Instead of installing golang from sources, it's easier to use golang image which is based on Debian Stretch. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 32a2331) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
We would like to use a version with .0 suffix (like 1.11.0) in Dockerfile, so that once a .1 version is out (like 1.11.1) we won't accidentally switch to it. Unfortunately it's not possible to use .0 suffix currently as it breaks the check in make.ps1. This patch fixes that. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 8ad648b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's that time of year again! Go 1.11 is released, time to use it. This commit also * removes our archive/tar fork, since upstream archive/tar is fixed for static builds, and osusergo build tag is set. * removes ENV GO_VERSION from Dockerfile as it's not needed anymore since PR moby#37592 is merged. [v2: switch to beta2] [v3: switch to beta3] [v4: rc1] [v5: remove ENV GO_VERSION as PR moby#37592 is now merged] [v6: rc2] [v7: final!] [v8: use 1.11.0] [v9: back to 1.11] [v8: use 1.11.0] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 10fd051) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
We can do that now as we're no longer carrying archive/tar. Note that latest vndr removes vendor/ subdir so we don't have to, thus the change in hack/validate/vendor. While at it, re-run a new vndr version to make sure everything that should be there is. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit ce858fe) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
...and use ugorji/go 1.1.1 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit a77a2a4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
As per https://github.com/etcd-io/etcd/blob/fa57f7fbc787b4/Gopkg.lock List of packages required by subset of etcd used is provided by: go list -f '{{join .Deps "\n"}}' \ github.com/docker/docker/vendor/github.com/coreos/etcd/... \ | grep -F . | grep -v coreos/etcd | sort | uniq Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 7008ac0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.1 (released 2018/10/01) includes fixes to the compiler, documentation, go command, runtime, and the crypto/x509, encoding/json, go/types, net, net/http, and reflect packages. See the Go 1.11.1 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 0347751) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Includes fixes to the compiler, linker, documentation, go command, and the database/sql and go/types packages. See the Go 1.11.2 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit e80ee52) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.13 (released 2018/12/14) - crypto/x509: CPU denial of service in chain validation golang/go#29233 - cmd/go: directory traversal in "go get" via curly braces in import paths golang/go#29231 - cmd/go: remote command execution during "go get -u" golang/go#29230 See the Go 1.11.3 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 6b7c093) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.4 (released 2018/12/14) includes fixes to cgo, the compiler, linker, runtime, documentation, go command, and the net/http and go/types packages. It includes a fix to a bug introduced in Go 1.11.3 that broke go get for import path patterns containing "...". See the Go 1.11.4 milestone for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 3770f38) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 7c8dceb) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
See the milestone for details; https://github.com/golang/go/issues?q=milestone%3AGo1.11.5+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 20b3441) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Full diff: golang/go@go1.11.5...go1.11.9 go1.11.6 (released 2019/03/14) includes fixes to cgo, the compiler, linker, runtime, go command, and the crypto/x509, encoding/json, net, and net/url packages. See the Go 1.11.6 milestone on our issue tracker for details. https://github.com/golang/go/issues?q=milestone%3AGo1.11.6 go1.11.7 (released 2019/04/05) includes fixes to the runtime and the net packages. See the Go 1.11.7 milestone on our issue tracker for details. https://github.com/golang/go/issues?q=milestone%3AGo1.11.7 go1.11.8 (released 2019/04/08) was accidentally released without its intended fix. It is identical to go1.11.7, except for its version number. The intended fix is in go1.11.9. go1.11.9 (released 2019/04/11) fixes an issue where using the prebuilt binary releases on older versions of GNU/Linux led to failures when linking programs that used cgo. Only Linux users who hit this issue need to update. See golang/go#31293 for details Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.10 (released 2019/05/06) includes fixes to the runtime and the linker. See the Go 1.11.10 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.10 Full diff: golang/go@go1.11.9...go1.11.10 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.11 (released 2019/06/11) includes a fix to the crypto/x509 package. See the Go 1.11.11 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.11 full diff: golang/go@go1.11.10...go1.11.11 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
372c5c7 to
a14e6ca
Compare
|
rebased again, because we merged quite some other PR's |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already in the 18.09 branch:
Included in this PR: