[18.09 backport] Update to Golang 1.12.6 #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euan Harris <euan.harris@docker.com> (cherry picked from commit ba41402) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Euan Harris <euan.harris@docker.com> (cherry picked from commit 5464285) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Euan Harris <euan.harris@docker.com> (cherry picked from commit 92ab908) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Euan Harris <euan.harris@docker.com> (cherry picked from commit 9b91d9e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
/cc @euanh |
euanh
approved these changes
Jun 27, 2019
|
Even if we don't actually update the compiler soon, we should take the |
|
I'm ok with merging this already; if you think we should, I'll remove "WIP" |
|
Is there a plan to get 18.09 running on Go 1.12? |
|
Plan is to keep all maintained releases at a supported Go version, and I think we should update it to 1.12 yes |
|
We could also use a build-arg, and make it a matrix (test against multiple Go versions) |
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2408 for the 18.09 branch
note that 18.09 is not yet running on Go 1.12, so we might want to hold off until that is merged (work in progress PR to move to 1.11; docker-archive/engine#168)
I'll add "WIP", but we can decide to already merge this if we think that's good to have