Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git in order to be able to run go get #239

Closed
wants to merge 1 commit into from

Conversation

jcabmora
Copy link

No description provided.

@jcabmora jcabmora changed the title Add git in order to be able to run go get Add git in order to be able to run go get Sep 23, 2018
@jcabmora
Copy link
Author

jcabmora commented Sep 23, 2018

Just noticed this comment. I think from a usability perspective, it does make sense to include git. Otherwise, (based on the PR history) people will keep running into the same issue (e.g. failed go get). Yes, you add about 15MB more to the image, but I think it is totally worth it.
I think you have to analyze what the target audience for this image is, which I believe is compile/test time as opposed to run time. (I might be wrong, but I would not use this image for distributing the apps that I am building, instead it is awesome resource to compile go sources.) I was looking into this image so I can provision build agents quickly, and the alternative of using the Ubuntu base image is not really a good one (750 MB!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant