Skip to content

rabbit_set_config can break rabbitmq.conf by omitting important new lines #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelklishin opened this issue Dec 29, 2020 · 1 comment · Fixed by #457
Closed

rabbit_set_config can break rabbitmq.conf by omitting important new lines #456

michaelklishin opened this issue Dec 29, 2020 · 1 comment · Fixed by #457
Labels

Comments

@michaelklishin
Copy link
Collaborator

See this RabbitMQ repository discussion. It looks like the rabbit_set_config function should make sure it prepends a newline character to every line it generates. Extra newlines won't hurt but missing newlines can produce an incorrect config file and cause a fair amount of confusion.

Of course, it would be best if this image did not mess with the rabbitmq.conf and retired all environment variable-based configuration values possible but we've had this conversation in #440 and #424 :)

@tianon
Copy link
Member

tianon commented Dec 29, 2020

Doh, yep - I bet the reproducer is to have a rabbitmq.conf that's missing a trailing newline and the container try to set an option that doesn't exist, which will append to the file. 😅

(Yes, I'd really love to resolve #424 😬)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants