Skip to content

If the provided rabbitmq.conf is missing a newline at EOF, add one before appending to it #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2020
Merged

If the provided rabbitmq.conf is missing a newline at EOF, add one before appending to it #457

merged 1 commit into from
Dec 29, 2020

Conversation

tianon
Copy link
Member

@tianon tianon commented Dec 29, 2020

Fixes #456

@tianon
Copy link
Member Author

tianon commented Dec 29, 2020

I verified my hunch from #456 (comment) by using echo -n 'foo = bar' to create a newline-free rabbitmq.conf file and saw that we did indeed append directly to it. Then I did the same with this branch and it no longer reproduces. 👍

@yosifkit yosifkit merged commit 205a944 into docker-library:master Dec 29, 2020
@yosifkit yosifkit deleted the newline-at-eof branch December 29, 2020 23:10
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 30, 2020
@docker-library-bot
Update rabbitmq
f70a4eb 
Changes:

- docker-library/rabbitmq@205a944: Merge pull request docker-library/rabbitmq#457 from infosiftr/newline-at-eof
- docker-library/rabbitmq@3644a01: If the provided rabbitmq.conf is missing a newline at EOF, add one before appending to it
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 30, 2020
@docker-library-bot
Update rabbitmq
39bb3f6 
Changes:

- docker-library/rabbitmq@0e59f96: Merge pull request docker-library/rabbitmq#458 from infosiftr/jq-template
- docker-library/rabbitmq@205a944: Merge pull request docker-library/rabbitmq#457 from infosiftr/newline-at-eof
- docker-library/rabbitmq@7e63843: Add initial jq-based templating engine
- docker-library/rabbitmq@3644a01: If the provided rabbitmq.conf is missing a newline at EOF, add one before appending to it
@tianon tianon mentioned this pull request Dec 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rabbit_set_config can break rabbitmq.conf by omitting important new lines
2 participants
@tianon @yosifkit